ci: harden workflows, upgrade actions, fix caching#248
ci: harden workflows, upgrade actions, fix caching#248umputun merged 1 commit intoumputun:masterfrom
Conversation
0b58602 to
7710f99
Compare
umputun
left a comment
There was a problem hiding this comment.
couple issues:
- bug in
app/main.go:304— the error variable was changed fromperrtoerr, but the assignment on line 301 still usesperr. this wraps the wrong error:
maxBodySize, perr := sizeParse(opts.MaxSize)
if perr != nil {
return fmt.Errorf("failed to convert MaxSize: %w", err) // should be perr
}-
app/mgmt/metrics.goremoves theFlush()method andserver_test.goremoves its tests — this reverts #247 (SSE streaming fix) merged a few days ago. was this intentional? -
docker.ymlreplaces theenv:var approach from #245 with direct${{ }}inrun:blocks. the env approach was specifically chosen to prevent shell injection — putting expressions back inline in run blocks reverses that hardening. -
the Go source changes (main.go alignment, defer cancel, server.go shutdown timeout, metrics.go Flusher removal) are unrelated to CI hardening. would be cleaner to split them into a separate PR, or at least mention them in the description.
CI workflow upgrades and permissions changes look good overall.
7710f99 to
6575fd8
Compare
6575fd8 to
6deccaa
Compare
|
Reverted all the go changes, fixed the env usage. Should be solid now. |
Summary