Open
Conversation
werebus
added a commit
that referenced
this pull request
Oct 14, 2025
Noticed this was one of the failures on #853
Merged
werebus
added a commit
that referenced
this pull request
Oct 15, 2025
* Re-enable some parentheses-related cops I don't have as strong an opinion as the person who wrote those comments * Be a little less permissive with block length * Exclude vendor from rubocop Noticed this was one of the failures on #853 * Bring complexity exceptions down to just-passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of these will fail now - I'm personally open to merging this and just not require the failing status checks for the time being. Sort of as an intrusive reminder to get things into compliance.
That being said I'll be putting up subsequent setup/fix PRs once I do my rounds.