Enable automatic signing for releases by Anbranin · Pull Request #477 · umts/pvta-multiplatform

Anbranin · 2018-10-09T19:00:56Z

Updated the Android doc and some packages.

…n by default

…g method and for accuracy.

Anbranin · 2018-10-09T19:08:53Z

I need someone who has never worked on PVTA-multiplatform before (hasn't set it up on their current computer, in any case) to try out these instructions.
@Chauce, @jforgue or @avacmeyer I don't think any of you have worked on it. Any volunteers?

…d-test

werebus

Just some suggestions.

werebus · 2018-10-09T20:59:33Z

doc/deploy/android.md

+### Android Studio
+We use Android Studio to easily manage the Android SDK tools. If you wish, you can attempt
+to download the tools separately, but these instructions will not help you because I found the
+attempt maddening. Plus, Android Studio will keep track of updates for you, which is nice.


This isn't too helpful in documentation.

werebus · 2018-10-09T20:59:37Z

doc/deploy/android.md

+  1. `$brew install gradle`
+  1. Follow any additional commands to set Gradle up.

+### Node


There's no way you don't already have node installed if anything else works for you while developing the app. (i.e. ionic and cordova also need node to run).

These instructions should work for someone who was instructed to deploy the application and never worked on it, even though that's unlikely. Or someone whose computer crashed before they got to deploy.
I'm going to push back against assuming anything.

Right, but we have instructions for that here:

https://github.com/umts/pvta-multiplatform#prerequisites

fiinnneneee

werebus · 2018-10-09T21:02:11Z

doc/deploy/android.md

+  an emulator or phone: `$ionic cordova build android`.
+  1. If you have an Android: Plug it into the computer with a USB cable and enable USB
+  debugging. Side-load like so, replacing the paths with your own:
+ `~/Library/Android/sdk/platform-tools/adb install /Users/my_name/pvta-multiplatform/platforms/android/build/outputs/apk/debug/android-debug.apk


Better to use placeholders here rather than full paths: <android_sdk>/platform_tools/adb install platforms/android/build/outputs/apk/debug/android-debug.apk

If I read that I'd be flummoxed by what that meant, but hopefully the people that read and use this have knowledge and minds more like yours and less like mine.

werebus · 2018-10-09T21:03:15Z

doc/deploy/android.md

+  1. Now you can build a release APK that should be signed automatically:
+  `$ionic cordova build android --prod --release`
+The terminal output should tell you your release location. If it's something like this:
+`/platforms/android/build/outputs/apk/release/android-release.apk`


Probably no leading /.

doc/deploy/android.md

werebus · 2018-10-09T21:05:30Z

doc/deploy/android.md

+  my location was `/Users/my_name/Library/Android/sdk`
+
+  For "JAVA_HOME" problems, find the location of your JDK installation. My location
+  was `/Library/Java/JavaVirtualMachines/jdk-11.jdk/Contents/Home` and I don't know how


Are you sure it's "jdk-11" Your instructions below seem to imply that you should be using Java 8 not Java 11.

Or, you're saying that's what is was but not what it should have been?

Woops I copied and pasted from a "failed examples" part of my running documentation. Fuxed

mboneil10

General comments. Wasn't able to make it all the way through once, but I will at some point this week.

mboneil10 · 2018-10-09T23:26:57Z

doc/deploy/android.md

-2. Open `config.xml`. On line 2, increment `android-versionCode` with your appropriately chosen new version number.
+### Android Studio
+We use Android Studio to easily manage the Android SDK tools. If you wish, you can attempt
+to download the tools separately, but these instructions will not help you because I found the


You can end the sentence here.

Well, I was trying to insert a little whimsy into an otherwise extremely dry document, but WHATEVER

mboneil10 · 2018-10-09T23:31:02Z

doc/deploy/android.md

+attempt maddening. Plus, Android Studio will keep track of updates for you, which is nice.
+1. Get [Android Studio](https://developer.android.com/studio/)
+1. Use it to download the SDK platforms and tools: 
+  1. Click menu items Android Studio -> Appearance and Behavior -> System Settings -> Android SDK


Instead of menu items, should we say Android Studio > Preferences > Appearance and Behavior ...? That's a bit clearer to me.

Ah yeah I was totally unclear. I meant "click the menu items "This" -> "that" -> "this"", not "click a button called 'menu items'. Will change so that's clearer.

doc/deploy/android.md

mboneil10 · 2018-10-09T23:37:22Z

doc/deploy/android.md

+  level 26, which we target at the moment. 
+  1. Click on the "tools" tab. Make sure "Android SDK Platform Tools", "Android SDK Tools", and
+  "Android SDK Build Tools" are checked. If you don't have access to an Android phone, make sure
+  the Emulator is also installed. Click "apply"


This is probably a job for someone who has never worked with pvtrack before, but I wonder if the emulator works.

I have no idea. Maybe I should take that part out, since I've never tried the emulator.

werebus · 2018-10-10T13:30:50Z

doc/deploy/android.md

+# Building an Android App to Deploy in Google Play

-##### Steps
+## Requirements


Worth mentioning, also, that almost all of these requirements are documented here:

https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html

I think it might be worth just linking to those instructions and these instructions:

https://cordova.apache.org/docs/en/latest/guide/platforms/ios/index.html

In the main readme rather than duplicating them here.

Oh god. I'm so sad right now.

mboneil10 · 2018-10-11T17:10:36Z

doc/deploy/android.md

+be downloaded separately, but these instructions do not cover how.
+1. Get [Android Studio](https://developer.android.com/studio/)
+1. Use it to download the SDK platforms and tools: 
+  1. Navigate through these menu items:


Are these indentations four spaces long?

No. You can actually tell from here if you highlight with your mouse.

Anbranin added 6 commits September 27, 2018 19:37

Maybe this is supposed to be here

b54754f

include target SDK version-otherwise it will be the latest SDK versio…

1e22df5

…n by default

some updates from making our first build

911fb38

automatic changes made from setup and making the first build. Updates?

88788d5

update documentation for Android to reflect new discoveries in signin…

132d428

…g method and for accuracy.

add example file and data, taking out password

70de4aa

Anbranin requested a review from mboneil10 October 9, 2018 19:00

tagging doesn't work in GH markdown docs

4cc80d0

Merge branch 'master' of github.com:umts/pvta-multiplatform into buil…

5d337a7

…d-test

werebus reviewed Oct 9, 2018

View reviewed changes

mboneil10 reviewed Oct 9, 2018

View reviewed changes

werebus reviewed Oct 10, 2018

View reviewed changes

Anbranin added 3 commits October 10, 2018 09:57

small edits for clarity

e23e627

I wonder if the emulator works

ae7ecf1

add how to verify a signed release APK

2cd12e6

mboneil10 reviewed Oct 11, 2018

View reviewed changes

Anbranin added 2 commits October 11, 2018 16:28

I was duplicating instructions the whole time

200abf5

strip this down more

dc003dc

Conversation

Anbranin commented Oct 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Anbranin commented Oct 9, 2018

Uh oh!

werebus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mboneil10 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Anbranin commented Oct 9, 2018 •

edited

Loading