-
Notifications
You must be signed in to change notification settings - Fork 84
SS4 Upgrade #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
SS4 Upgrade #92
Conversation
…r a file has been uploaded
|
@gordonbanderson see also #79. Don't care which one is merged just be good to one merged @unclecheese |
|
hi @unclecheese , I'd go with @wilr pull request for now, this PR I got chunked file uploads working, but I was not 100% sure of the rest of the functionality and I'd also broken non chunked uploads :( I had some major upheaval life wise just after doing this (my father died, I moved back to the UK), and my head is only now returning to 'code mode'. I'm currently traveling, will aim to get back to full time coding in just over a month and sort out my various SS4 upgrades. It's another +1 for the @wilr PR Cheers Gordon |
|
Feel free to close this PR, I am not currently in a position to support it, and I will have a look at the chunking aspect when I am back in the UK |
I've never used this module before, and I'm not sure how to set up the uploader with multi file relation, as such I've not tested that. However it is working with a single file.