ci: re-enable Dockerfile.ssl in validate matrix#299
Merged
Conversation
The ssl-manager package on GHCR is now public, so the validation job can pull it without registry auth. Restores the matrix row, drops the now-unnecessary packages:read permission, and replaces the privacy caveat comment with a note on what to do if it ever goes private again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Now that `ghcr.io/unicitynetwork/ssl-manager` is public, the validate workflow can pull it anonymously. Restores `Dockerfile.ssl` in the matrix row that #298 had to skip.
Test plan