Add leaves into smt after db has finished

[martti007]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @martti007, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on refining the data processing flow to ensure that Sparse Merkle Tree (SMT) leaves are added only after their corresponding data has been successfully persisted to the database, thereby enhancing data integrity. Additionally, it includes routine dependency updates for core database libraries (mongodb and mongoose) to leverage the latest features and bug fixes, and cleans up the TypeScript configuration for better maintainability.

Highlights

• SMT Leaf Addition Logic: I've reordered the logic in src/RoundManager.ts to ensure that leaves are added to the Sparse Merkle Tree (SMT) only after the database storage operations for records and SMT leaves have successfully completed. This change aligns with the PR title's intent to ensure data consistency by processing SMT updates post-database persistence.
• Dependency Updates: I've updated the mongodb and mongoose packages to their latest versions (6.17.0 and 8.16.2 respectively) in both package.json and package-lock.json. This also includes an update to the bson dependency from 6.10.3 to 6.10.4.
• TypeScript Configuration Cleanup: I've removed the explicit paths configuration for the threads module from tsconfig.json. This simplifies the TypeScript setup, as these explicit mappings are no longer necessary, likely due to improved module resolution or updates in the threads package itself.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates mongodb and mongoose dependencies and refactors the block creation logic in RoundManager. The change to RoundManager correctly defers the in-memory SMT update until after the database persistence calls have completed, which improves robustness. However, I've identified a potential data integrity issue where the database writes for records and SMT leaves are not performed atomically. My review includes a high-severity comment with a recommendation to wrap these operations in a transaction to prevent inconsistent database states.

[gemini-code-assist]

The recordStoragePromise and smtLeafStoragePromise are executed in parallel but not within a database transaction. If one of these operations succeeds and the other fails, the database will be left in an inconsistent state. For example, the aggregator records might be saved, but the corresponding SMT leaves might not be. To ensure atomicity, these two putBatch operations should be wrapped in a single transaction.

try {
  await withTransaction(async (session) => {
    const p1 = aggregatorRecords.length > 0 ? this.recordStorage.putBatch(aggregatorRecords, session) : Promise.resolve(true);
    const p2 = smtLeafStoragePromise = smtLeaves.length > 0 ? this.smtStorage.putBatch(smtLeaves, session) : Promise.resolve(true);
    await Promise.all([p1, p2]);
  });
} catch (error) {
  loggerWithMetadata.error('Failed to store records and SMT leaves transactionally:', error);
  throw error;
}