Disable deployment to redundant instances

[marttonso]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @marttonso, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on optimizing our deployment strategy by removing specific redundant instances from the Ansible inventory. The change ensures that future deployments will no longer target these machines, contributing to a more efficient and streamlined deployment process.

Highlights

• Deployment Configuration: I have updated the ansible/inventory.ini file to disable deployment to two specific aggregator instances: aggregator-test-2.mainnet-v4.internal in the [mainnet_v4_test] group and aggregator-2.mainnet-v4.internal in the [mainnet_v4] group. This was achieved by commenting out their entries.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request disables deployment to secondary aggregator instances in both the test and production-like environments by commenting them out in the Ansible inventory. My review focuses on the significant operational risk this introduces by removing redundancy and creating a single point of failure. I have raised a high-severity issue requesting that the author provide context for this change in the pull request description and have suggested alternative ways to implement this change for better long-term maintainability.

[gemini-code-assist]

Commenting out these instances removes high availability for both the mainnet_v4_test and mainnet_v4 environments. This creates a single point of failure; if the remaining aggregator instance (aggregator-test-1 or aggregator-1) goes down, the service will be completely unavailable.

The pull request description is empty, which makes it difficult to understand the reasoning behind such a high-impact change. To ensure this is an intended and accepted risk, please update the PR description to clarify:

• The rationale for removing this redundancy.
• Whether this is a temporary or permanent change.

For long-term maintainability:

• If this is a permanent removal, it's better to delete the lines entirely.
• If this is temporary, please add a comment in the inventory.ini file explaining the context and expected duration (e.g., # Temporarily disabled for maintenance until YYYY-MM-DD).