Skip to content

Add partition-params #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lploom merged 1 commit into from
Mar 12, 2026
Merged

Add partition-params #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cli/ubft/cmd/shard_conf_generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ type (
EpochStart uint64
T2Timeout uint32
NodeInfoFiles []string
PartitionParams map[string]string
}
)

Expand All @@ -48,6 +49,7 @@ func shardConfGenerateCmd(baseFlags *baseFlags) *cobra.Command {
panic(err)
}
cmd.Flags().StringSliceVarP(&flags.NodeInfoFiles, "node-info", "n", []string{}, "path to node info files")
cmd.Flags().StringToStringVar(&flags.PartitionParams, "partition-params", nil, "partition parameters as key=value pairs")

return cmd
}
Expand Down Expand Up @@ -85,6 +87,7 @@ func shardConfGenerate(flags *ShardConfGenerateFlags) error {
UnitIDLen: 256,
T2Timeout: time.Duration(flags.T2Timeout) * time.Millisecond,
Validators: nodes,
PartitionParams: flags.PartitionParams,
}

if err = shardConf.IsValid(); err != nil {
Expand Down
6 changes: 5 additions & 1 deletion cli/ubft/cmd/shard_conf_generate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@ import (
"testing"

"github.com/stretchr/testify/require"
testobserve "github.com/unicitynetwork/bft-core/internal/testutils/observability"
"github.com/unicitynetwork/bft-go-base/types"
"github.com/unicitynetwork/bft-go-base/util"

testobserve "github.com/unicitynetwork/bft-core/internal/testutils/observability"
)

func TestShardConf_Generate(t *testing.T) {
Expand All @@ -33,6 +34,7 @@ func TestShardConf_Generate(t *testing.T) {
"--partition-type-id", "1",
"--epoch", "8",
"--epoch-start", "100",
"--partition-params", "dFG=6",
})
require.NoError(t, cmd.Execute(context.Background()))

Expand All @@ -45,4 +47,6 @@ func TestShardConf_Generate(t *testing.T) {
require.Equal(t, uint64(8), rec.Epoch)
require.Equal(t, uint64(100), rec.EpochStart)
require.Len(t, rec.Validators, 1)
require.Len(t, rec.PartitionParams, 1)
require.Equal(t, "6", rec.PartitionParams["dFG"])
}
Loading