Skip to content

Cbor tags#19

Merged
MastaP merged 4 commits intomainfrom
issue-18-cbor_tags
Apr 13, 2026
Merged

Cbor tags#19
MastaP merged 4 commits intomainfrom
issue-18-cbor_tags

Conversation

@MastaP
Copy link
Copy Markdown
Member

@MastaP MastaP commented Apr 10, 2026

No description provided.

@MastaP MastaP requested a review from lploom April 10, 2026 21:59
@MastaP MastaP self-assigned this Apr 10, 2026
@MastaP MastaP linked an issue Apr 10, 2026 that may be closed by this pull request
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the bft-go-base dependency and modifies the ExecutedBlock serialization, as evidenced by the updated test hashes and the addition of ShardTreeCertificate to the UnicityCertificate struct. It also refactors the BoltDB storage initialization by removing legacy migration logic (version 0 to 1) and enforcing a strict version check. A critical review comment suggests incrementing the database version to 2, as the serialization changes make existing version 1 databases incompatible with the new code.

Comment thread rootchain/consensus/storage/db_bolt.go
@MastaP MastaP merged commit 2f52ec1 into main Apr 13, 2026
3 checks passed
@MastaP MastaP deleted the issue-18-cbor_tags branch April 13, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TGE] Update BFT node implementation to use the new type tags

2 participants