#52 Add general structure, token minting and transfering functionality.

[martti007]

No description provided.

[Copilot]

Pull request overview

This PR introduces a new “certification request + CBOR-centric” flow to support token minting/transfer certification and verification, alongside a broad package/API refactor (hashing/crypto, predicates, BFT verification, JSON-RPC namespaces) and significant test suite restructuring/removals.

Changes:

• Replace legacy “submit_commitment / RequestId” flow with “certification_request / StateId” + new certification models and inclusion proof parsing.
• Add new verification framework (util.verification) and transaction-level verification rules for certified mint/transfer.
• Refactor/relocate crypto/hash, predicate engines/verifiers, and BFT verification into new packages; update/trim tests and fixtures accordingly.

Reviewed changes

Copilot reviewed 212 out of 212 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/test/java/org/unicitylabs/sdk/utils/helpers/PendingTransfer.java	Removed legacy test helper.
src/test/java/org/unicitylabs/sdk/utils/helpers/CommitmentResult.java	Removed legacy test helper/result model.
src/test/java/org/unicitylabs/sdk/utils/TestTokenData.java	Removed legacy test token data wrapper.
src/test/java/org/unicitylabs/sdk/transaction/MintTransactionFixture.java	Removed legacy mint fixture.
src/test/java/org/unicitylabs/sdk/transaction/InclusionProofFixture.java	Removed legacy inclusion proof fixture (transaction pkg).
src/test/java/org/unicitylabs/sdk/transaction/CommitmentTest.java	Removed legacy JSON serialization test.
src/test/java/org/unicitylabs/sdk/token/TokenTest.java	Removed legacy token JSON serialization test.
src/test/java/org/unicitylabs/sdk/token/TokenIdTest.java	Updated test to new TokenId/bitstring behavior.
src/test/java/org/unicitylabs/sdk/predicate/MaskedPredicateReferenceTest.java	Removed legacy predicate reference test.
src/test/java/org/unicitylabs/sdk/mtree/plain/SparseMerkleTreeTest.java	Updated HashAlgorithm import path.
src/test/java/org/unicitylabs/sdk/mtree/plain/SparseMerkleTreePathFixture.java	Updated hasher/hash imports for crypto refactor.
src/test/java/org/unicitylabs/sdk/mtree/plain/MerkleTreePathTest.java	Switched from JSON mapper usage to CBOR serializer usage in test.
src/test/java/org/unicitylabs/sdk/mtree/plain/MerkleTreePathStepTest.java	Removed legacy JSON serialization test for path step.
src/test/java/org/unicitylabs/sdk/mtree/CommonPathTest.java	Removed unnecessary throws Exception from test signature.
src/test/java/org/unicitylabs/sdk/jsonrpc/JsonRpcResponseTest.java	Updated imports for moved JsonRpcResponse.
src/test/java/org/unicitylabs/sdk/jsonrpc/JsonRpcRequestTest.java	Updated imports for moved JsonRpcRequest.
src/test/java/org/unicitylabs/sdk/hash/DataHasherTest.java	Updated to crypto.hash package classes.
src/test/java/org/unicitylabs/sdk/hash/DataHashTest.java	Updated to CBOR serialization expectations for DataHash.
src/test/java/org/unicitylabs/sdk/functional/FunctionalTokenSplitTest.java	Removed legacy functional split test.
src/test/java/org/unicitylabs/sdk/functional/FunctionalEscrowSwapTest.java	Removed legacy functional escrow swap test.
src/test/java/org/unicitylabs/sdk/functional/FunctionalCommonFlowTest.java	Updated setup to new TestAggregatorClient factory + predicate verifier.
src/test/java/org/unicitylabs/sdk/e2e/config/CucumberConfiguration.java	Removed legacy cucumber DI/test-lifecycle config.
src/test/java/org/unicitylabs/sdk/e2e/TokenE2ETest.java	Safer trust-base resource handling + predicate verifier initialization; updated RootTrustBase import.
src/test/java/org/unicitylabs/sdk/e2e/E2EEscrowSwapTest.java	Removed legacy E2E escrow swap test.
src/test/java/org/unicitylabs/sdk/e2e/CucumberTestRunner.java	Removed commented cucumber runner class.
src/test/java/org/unicitylabs/sdk/crypto/secp256k1/SigningServiceTest.java	Updated package/name alignment and test data usage.
src/test/java/org/unicitylabs/sdk/crypto/secp256k1/SignatureRecoveryTest.java	Updated package/imports to crypto.secp256k1 and crypto.hash.
src/test/java/org/unicitylabs/sdk/api/bft/UnicityCertificateUtils.java	Moved test utils to api.bft package; updated crypto imports.
src/test/java/org/unicitylabs/sdk/api/bft/UnicityCertificateTest.java	Updated package/imports; removed unnecessary IOException throws.
src/test/java/org/unicitylabs/sdk/api/bft/RootTrustBaseUtils.java	Moved/updated RootTrustBase utilities package/imports.
src/test/java/org/unicitylabs/sdk/api/bft/RootTrustBaseTest.java	Updated package/imports; removed unnecessary IOException throws.
src/test/java/org/unicitylabs/sdk/api/RequestIdTest.java	Removed legacy RequestId test (RequestId removed).
src/test/java/org/unicitylabs/sdk/api/InclusionProofFixture.java	Added new api-level inclusion proof fixture returning InclusionProofResponse.
src/test/java/org/unicitylabs/sdk/api/AuthenticatorTest.java	Removed legacy authenticator JSON test.
src/test/java/org/unicitylabs/sdk/MockAggregatorServer.java	Updated protected method + dispatcher handling for certification_request.
src/test/java/org/unicitylabs/sdk/AndroidCompatibilityTest.java	Updated imports and signing/hash usage for crypto refactor.
src/main/java/org/unicitylabs/sdk/verification/VerificationRule.java	Removed legacy verification framework base rule.
src/main/java/org/unicitylabs/sdk/verification/VerificationResultCode.java	Removed legacy verification result code enum.
src/main/java/org/unicitylabs/sdk/verification/VerificationResult.java	Removed legacy verification result model.
src/main/java/org/unicitylabs/sdk/verification/VerificationException.java	Removed legacy checked exception for verification failures.
src/main/java/org/unicitylabs/sdk/verification/VerificationContext.java	Removed legacy verification context interface.
src/main/java/org/unicitylabs/sdk/verification/CompositeVerificationRule.java	Removed legacy composite verification rule chain.
src/main/java/org/unicitylabs/sdk/util/verification/VerificationStatus.java	Added new lightweight OK/FAIL status enum.
src/main/java/org/unicitylabs/sdk/util/verification/VerificationResult.java	Added new generic verification result container with nested results.
src/main/java/org/unicitylabs/sdk/util/verification/VerificationException.java	Added new runtime verification exception carrying VerificationResult.
src/main/java/org/unicitylabs/sdk/util/verification/VerificationContext.java	Added new verification context marker interface.
src/main/java/org/unicitylabs/sdk/util/HexConverter.java	Minor formatting change to private constructor.
src/main/java/org/unicitylabs/sdk/util/BitString.java	Reworked helper to build BitString from StateId (instead of DataHash).
src/main/java/org/unicitylabs/sdk/transaction/verification/InclusionProofVerificationStatus.java	Added richer inclusion proof verification status enum (new pkg).
src/main/java/org/unicitylabs/sdk/transaction/verification/InclusionProofVerificationRule.java	Added inclusion proof verification logic producing typed status results.
src/main/java/org/unicitylabs/sdk/transaction/verification/CertifiedTransferTransactionVerificationRule.java	Added verification for certified transfer transaction vs previous tx.
src/main/java/org/unicitylabs/sdk/transaction/verification/CertifiedMintTransactionVerificationRule.java	Added verification for certified mint transaction + lock script checks.
src/main/java/org/unicitylabs/sdk/transaction/split/SplitMintReasonProof.java	Removed legacy split mint reason proof type.
src/main/java/org/unicitylabs/sdk/transaction/TransferCommitment.java	Removed legacy transfer commitment object.
src/main/java/org/unicitylabs/sdk/transaction/TransactionData.java	Removed legacy transaction data interface.
src/main/java/org/unicitylabs/sdk/transaction/Transaction.java	Replaced abstract transaction class with a new Transaction interface.
src/main/java/org/unicitylabs/sdk/transaction/TokenType.java	Added new TokenType type under transaction pkg with CBOR + bitstring support.
src/main/java/org/unicitylabs/sdk/transaction/TokenId.java	Added new TokenId type under transaction pkg with CBOR + bitstring support.
src/main/java/org/unicitylabs/sdk/transaction/MintTransactionState.java	Reworked mint state derivation to CBOR-hash approach; added null check.
src/main/java/org/unicitylabs/sdk/transaction/MintTransactionReasonJson.java	Removed legacy mint reason JSON deserializer.
src/main/java/org/unicitylabs/sdk/transaction/MintTransactionReason.java	Removed legacy mint reason interface.
src/main/java/org/unicitylabs/sdk/transaction/MintReasonType.java	Removed legacy mint reason type enum.
src/main/java/org/unicitylabs/sdk/transaction/MintCommitment.java	Removed legacy mint commitment object.
src/main/java/org/unicitylabs/sdk/transaction/InclusionProofVerificationStatus.java	Removed legacy inclusion proof verification status enum (old pkg).
src/main/java/org/unicitylabs/sdk/transaction/Commitment.java	Removed legacy commitment abstraction.
src/main/java/org/unicitylabs/sdk/transaction/CertifiedTransferTransaction.java	Added wrapper type representing a transfer transaction with verified inclusion proof.
src/main/java/org/unicitylabs/sdk/transaction/CertifiedMintTransaction.java	Added wrapper type representing a mint transaction with verified inclusion proof.
src/main/java/org/unicitylabs/sdk/transaction/Address.java	Added new Address value type (hash-of-predicate based) with CBOR support.
src/main/java/org/unicitylabs/sdk/token/fungible/TokenCoinDataJson.java	Removed legacy JSON serializer/deserializer for TokenCoinData.
src/main/java/org/unicitylabs/sdk/token/fungible/TokenCoinData.java	Removed legacy TokenCoinData type.
src/main/java/org/unicitylabs/sdk/token/fungible/CoinIdJson.java	Removed legacy CoinId JSON serializer/deserializer.
src/main/java/org/unicitylabs/sdk/token/fungible/CoinId.java	Removed legacy CoinId type.
src/main/java/org/unicitylabs/sdk/token/TokenTypeJson.java	Removed legacy token.TokenType JSON serializer/deserializer.
src/main/java/org/unicitylabs/sdk/token/TokenType.java	Removed legacy token.TokenType type.
src/main/java/org/unicitylabs/sdk/token/TokenIdJson.java	Removed legacy token.TokenId JSON serializer/deserializer.
src/main/java/org/unicitylabs/sdk/token/TokenId.java	Removed legacy token.TokenId type.
src/main/java/org/unicitylabs/sdk/signing/SignatureJson.java	Removed legacy signature JSON serializer/deserializer.
src/main/java/org/unicitylabs/sdk/signing/MintSigningService.java	Removed legacy signing.MintSigningService (moved to crypto).
src/main/java/org/unicitylabs/sdk/serializer/json/ByteArrayJson.java	Minor Javadoc formatting change.
src/main/java/org/unicitylabs/sdk/serializer/json/BigIntegerAsStringSerializer.java	Removed legacy BigInteger-as-string serializer.
src/main/java/org/unicitylabs/sdk/serializer/cbor/CborDeserializer.java	Renamed APIs to decode* and adjusted constructor formatting.
src/main/java/org/unicitylabs/sdk/serializer/UnicityObjectMapper.java	Minor formatting change to private constructor.
src/main/java/org/unicitylabs/sdk/predicate/verification/PredicateVerifierService.java	Added predicate verifier registry/service.
src/main/java/org/unicitylabs/sdk/predicate/verification/PredicateVerifier.java	Added predicate verifier interface.
src/main/java/org/unicitylabs/sdk/predicate/embedded/UnmaskedPredicateReference.java	Removed legacy embedded predicate reference.
src/main/java/org/unicitylabs/sdk/predicate/embedded/UnmaskedPredicate.java	Removed legacy embedded predicate implementation.
src/main/java/org/unicitylabs/sdk/predicate/embedded/MaskedPredicateReference.java	Removed legacy embedded predicate reference.
src/main/java/org/unicitylabs/sdk/predicate/embedded/MaskedPredicate.java	Removed legacy embedded predicate implementation.
src/main/java/org/unicitylabs/sdk/predicate/embedded/EmbeddedPredicateType.java	Removed legacy embedded predicate type enum.
src/main/java/org/unicitylabs/sdk/predicate/embedded/EmbeddedPredicateEngine.java	Removed legacy embedded predicate engine.
src/main/java/org/unicitylabs/sdk/predicate/embedded/BurnPredicateReference.java	Removed legacy burn predicate reference.
src/main/java/org/unicitylabs/sdk/predicate/builtin/verification/PayToPublicKeyPredicateVerifier.java	Added verifier for PAY_TO_PUBLIC_KEY built-in predicate.
src/main/java/org/unicitylabs/sdk/predicate/builtin/verification/BuiltInPredicateVerifier.java	Added built-in predicate verifier interface (verification pkg).
src/main/java/org/unicitylabs/sdk/predicate/builtin/PayToPublicKeyPredicateUnlockScript.java	Added unlock-script helper for PAY_TO_PUBLIC_KEY signatures.
src/main/java/org/unicitylabs/sdk/predicate/builtin/PayToPublicKeyPredicate.java	Added PAY_TO_PUBLIC_KEY predicate type (built-in engine).
src/main/java/org/unicitylabs/sdk/predicate/builtin/BuiltInPredicateVerifier.java	Added built-in predicate verifier adapter implementing PredicateVerifier.
src/main/java/org/unicitylabs/sdk/predicate/builtin/BuiltInPredicateType.java	Added built-in predicate type enum.
src/main/java/org/unicitylabs/sdk/predicate/builtin/BuiltInPredicate.java	Added marker interface for built-in predicates.
src/main/java/org/unicitylabs/sdk/predicate/SerializablePredicateJson.java	Removed legacy JSON serializer/deserializer for predicates.
src/main/java/org/unicitylabs/sdk/predicate/SerializablePredicate.java	Removed legacy serializable predicate interface.
src/main/java/org/unicitylabs/sdk/predicate/PredicateReference.java	Removed legacy predicate reference interface.
src/main/java/org/unicitylabs/sdk/predicate/PredicateEngineType.java	Removed legacy predicate engine type enum.
src/main/java/org/unicitylabs/sdk/predicate/PredicateEngineService.java	Removed legacy predicate engine service.
src/main/java/org/unicitylabs/sdk/predicate/PredicateEngine.java	Replaced interface with enum-based engine identifiers.
src/main/java/org/unicitylabs/sdk/predicate/Predicate.java	Simplified predicate interface; added isEqualTo helper.
src/main/java/org/unicitylabs/sdk/mtree/sum/SparseMerkleSumTreeRootNode.java	Updated to crypto.hash imports.
src/main/java/org/unicitylabs/sdk/mtree/sum/SparseMerkleSumTreePathStep.java	Removed JSON annotations; updated CBOR deserializer API usage.
src/main/java/org/unicitylabs/sdk/mtree/sum/SparseMerkleSumTreePath.java	Removed JSON annotations; updated CBOR deserializer API usage + crypto.hash imports.
src/main/java/org/unicitylabs/sdk/mtree/sum/SparseMerkleSumTree.java	Updated HashAlgorithm import + Javadoc formatting.
src/main/java/org/unicitylabs/sdk/mtree/sum/PendingNodeBranch.java	Updated HashAlgorithm import.
src/main/java/org/unicitylabs/sdk/mtree/sum/PendingLeafBranch.java	Updated HashAlgorithm import.
src/main/java/org/unicitylabs/sdk/mtree/sum/FinalizedNodeBranch.java	Updated to crypto.hash imports.
src/main/java/org/unicitylabs/sdk/mtree/sum/FinalizedLeafBranch.java	Updated to crypto.hash imports.
src/main/java/org/unicitylabs/sdk/mtree/sum/FinalizedBranch.java	Updated DataHash import to crypto.hash.
src/main/java/org/unicitylabs/sdk/mtree/sum/Branch.java	Updated HashAlgorithm import to crypto.hash.
src/main/java/org/unicitylabs/sdk/mtree/plain/SparseMerkleTreeRootNode.java	Updated to crypto.hash imports.
src/main/java/org/unicitylabs/sdk/mtree/plain/SparseMerkleTreePathStep.java	Removed JSON annotations; updated CBOR deserializer API usage.
src/main/java/org/unicitylabs/sdk/mtree/plain/SparseMerkleTree.java	Updated HashAlgorithm import + Javadoc formatting.
src/main/java/org/unicitylabs/sdk/mtree/plain/PendingNodeBranch.java	Updated HashAlgorithm import.
src/main/java/org/unicitylabs/sdk/mtree/plain/PendingLeafBranch.java	Updated HashAlgorithm import.
src/main/java/org/unicitylabs/sdk/mtree/plain/FinalizedNodeBranch.java	Updated to crypto.hash imports.
src/main/java/org/unicitylabs/sdk/mtree/plain/FinalizedLeafBranch.java	Updated to crypto.hash imports.
src/main/java/org/unicitylabs/sdk/mtree/plain/FinalizedBranch.java	Updated DataHash import to crypto.hash.
src/main/java/org/unicitylabs/sdk/mtree/plain/Branch.java	Updated HashAlgorithm import to crypto.hash.
src/main/java/org/unicitylabs/sdk/hash/DataHashJson.java	Removed legacy JSON serializer/deserializer for DataHash.
src/main/java/org/unicitylabs/sdk/crypto/secp256k1/SigningService.java	Moved signing service to crypto.secp256k1; removed masked-secret factory; added generate().
src/main/java/org/unicitylabs/sdk/crypto/secp256k1/Signature.java	Moved signature to crypto.secp256k1; added CBOR encode/decode helpers.
src/main/java/org/unicitylabs/sdk/crypto/hash/UnsupportedHashAlgorithmException.java	Moved exception to crypto.hash package.
src/main/java/org/unicitylabs/sdk/crypto/hash/HashAlgorithm.java	Moved to crypto.hash; added length metadata.
src/main/java/org/unicitylabs/sdk/crypto/hash/DataHasher.java	Moved to crypto.hash; updated docs formatting.
src/main/java/org/unicitylabs/sdk/crypto/hash/DataHash.java	Moved to crypto.hash; removed JSON methods; added length validation + CBOR decode update.
src/main/java/org/unicitylabs/sdk/crypto/MintSigningService.java	Added crypto MintSigningService (replaces signing.MintSigningService).
src/main/java/org/unicitylabs/sdk/bft/verification/rule/UnicitySealQuorumSignaturesVerificationRule.java	Removed legacy BFT verification rule chain implementation.
src/main/java/org/unicitylabs/sdk/bft/verification/rule/InputRecordCurrentHashVerificationRule.java	Removed legacy BFT verification rule.
src/main/java/org/unicitylabs/sdk/bft/verification/UnicityCertificateVerificationRule.java	Removed legacy composite BFT verification rule chain.
src/main/java/org/unicitylabs/sdk/bft/verification/UnicityCertificateVerificationContext.java	Removed legacy verification context.
src/main/java/org/unicitylabs/sdk/bft/UnicityCertificateJson.java	Removed legacy UnicityCertificate JSON serializer/deserializer.
src/main/java/org/unicitylabs/sdk/api/jsonrpc/JsonRpcResponse.java	Moved JsonRpcResponse into api.jsonrpc package.
src/main/java/org/unicitylabs/sdk/api/jsonrpc/JsonRpcRequest.java	Moved JsonRpcRequest into api.jsonrpc package.
src/main/java/org/unicitylabs/sdk/api/jsonrpc/JsonRpcNetworkException.java	Moved JsonRpcNetworkException into api.jsonrpc package.
src/main/java/org/unicitylabs/sdk/api/jsonrpc/JsonRpcHttpTransport.java	Moved JsonRpcHttpTransport into api.jsonrpc package; minor this. usage fix.
src/main/java/org/unicitylabs/sdk/api/jsonrpc/JsonRpcError.java	Moved JsonRpcError into api.jsonrpc package.
src/main/java/org/unicitylabs/sdk/api/bft/verification/rule/UnicitySealHashMatchesWithRootHashRule.java	Added new BFT verification rule (seal hash vs tree root).
src/main/java/org/unicitylabs/sdk/api/bft/verification/rule/InputRecordCurrentHashVerificationRule.java	Added new BFT verification rule for input record hash.
src/main/java/org/unicitylabs/sdk/api/bft/verification/UnicityCertificateVerificationResult.java	Added new typed result wrapper for BFT verification.
src/main/java/org/unicitylabs/sdk/api/bft/verification/UnicityCertificateVerification.java	Added new BFT verification pipeline using util.verification results.
src/main/java/org/unicitylabs/sdk/api/bft/UnicityTreeCertificate.java	Moved into api.bft; updated CBOR deserialization method names.
src/main/java/org/unicitylabs/sdk/api/bft/UnicitySeal.java	Moved into api.bft; updated CBOR deserialization method names.
src/main/java/org/unicitylabs/sdk/api/bft/UnicityCertificate.java	Moved into api.bft; removed JSON annotations; updated CBOR deserialization method names.
src/main/java/org/unicitylabs/sdk/api/bft/ShardTreeCertificate.java	Moved into api.bft; updated CBOR deserialization method names.
src/main/java/org/unicitylabs/sdk/api/bft/RootTrustBase.java	Moved into api.bft package.
src/main/java/org/unicitylabs/sdk/api/bft/InputRecord.java	Moved into api.bft; updated CBOR deserialization method names.
src/main/java/org/unicitylabs/sdk/api/SubmitCommitmentStatus.java	Removed legacy submit commitment status enum.
src/main/java/org/unicitylabs/sdk/api/SubmitCommitmentRequest.java	Removed legacy submit commitment request type.
src/main/java/org/unicitylabs/sdk/api/StateId.java	Added StateId (hash of lockScript + state hash) with CBOR support and BitString conversion.
src/main/java/org/unicitylabs/sdk/api/RequestIdJson.java	Removed legacy RequestId JSON deserializer.
src/main/java/org/unicitylabs/sdk/api/RequestId.java	Removed legacy RequestId implementation.
src/main/java/org/unicitylabs/sdk/api/LeafValue.java	Removed legacy leaf value helper.
src/main/java/org/unicitylabs/sdk/api/JsonRpcAggregatorClient.java	Updated aggregator API: certification request submission + v2 inclusion proof decoding.
src/main/java/org/unicitylabs/sdk/api/InclusionProofResponse.java	Switched InclusionProofResponse to CBOR (de)serialization; added block number field.
src/main/java/org/unicitylabs/sdk/api/InclusionProofRequest.java	Changed request payload from RequestId to StateId bytes.
src/main/java/org/unicitylabs/sdk/api/CertificationStatus.java	Added certification status enum for new API.
src/main/java/org/unicitylabs/sdk/api/CertificationResponse.java	Renamed/repurposed response type from SubmitCommitmentResponse to CertificationResponse.
src/main/java/org/unicitylabs/sdk/api/CertificationRequest.java	Added CBOR certification request wrapper including derived StateId.
src/main/java/org/unicitylabs/sdk/api/AggregatorClient.java	Updated client interface to certification request + StateId-based inclusion proof.
src/main/java/org/unicitylabs/sdk/address/ProxyAddress.java	Removed legacy proxy address scheme.
src/main/java/org/unicitylabs/sdk/address/DirectAddress.java	Removed legacy direct address scheme.
src/main/java/org/unicitylabs/sdk/address/AddressScheme.java	Removed legacy address scheme enum.
src/main/java/org/unicitylabs/sdk/address/AddressJson.java	Removed legacy address JSON serializer/deserializer.
src/main/java/org/unicitylabs/sdk/address/AddressFactory.java	Removed legacy address factory/parser.
src/main/java/org/unicitylabs/sdk/address/Address.java	Removed legacy address interface.
README.md	Updated docs for CertificationResponse/CertificationStatus; needs formatting fixes.
.devcontainer/devcontainer.json	Added devcontainer configuration for Java/Gradle workflow.

Comments suppressed due to low confidence (1)

src/main/java/org/unicitylabs/sdk/api/CertificationResponse.java:77

• CertificationResponse still contains multiple legacy references to "Submit commitment" (class Javadoc, method docs, and toString() label). This is now misleading and makes logs/debugging confusing. Please update the documentation strings and toString() to reflect the new CertificationResponse naming.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.