-
-
Notifications
You must be signed in to change notification settings - Fork 35
Add :percent #1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Add :percent #1094
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c50f5d9
Add :percent
eemeli c64d781
Apply suggestions from code review
eemeli 2cfa500
Apply suggestions from code review
eemeli 277649d
Update exploration/percent-format.md
eemeli 2fc35ac
Use "numerical value" instead of "resolved value" where appropriate
eemeli a1dccbf
Update spec/functions/number.md
eemeli 54ed7b7
Fix section titles to match the style of PR #1096
eemeli 90f1b87
Refer to _numeric operand_ term
eemeli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -204,6 +204,7 @@ | |
"type": "array", | ||
"items": { | ||
"enum": [ | ||
":percent", | ||
"u:dir", | ||
"u:id", | ||
"u:locale" | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
{ | ||
"$schema": "../../schemas/v0/tests.schema.json", | ||
"scenario": "Percent function", | ||
"description": "The built-in formatter and selector for percent values.", | ||
"defaultTestProperties": { | ||
"tags": [":percent"], | ||
"bidiIsolation": "none", | ||
"locale": "en-US", | ||
"expErrors": [] | ||
}, | ||
"tests": [ | ||
{ | ||
"src": "{:percent}", | ||
"expErrors": [{ "type": "bad-operand" }], | ||
"exp": "{:percent}" | ||
}, | ||
{ | ||
"src": "{foo :percent}", | ||
"expErrors": [{ "type": "bad-operand" }], | ||
"exp": "{|foo|}" | ||
}, | ||
{ "src": "{1 :percent}" }, | ||
{ "src": ".local $n = {0.42 :number} {{{$n :percent}}}" }, | ||
{ "src": ".local $n = {42 :integer} {{{$n :percent}}}" }, | ||
{ "src": ".local $n = {0.01 :percent} {{{$n :percent}}}" }, | ||
{ "src": "{0.12345678 :percent}" }, | ||
{ "src": "{0.12345678 :percent maximumFractionDigits=1}" }, | ||
{ "src": "{0.12 :percent minimumFractionDigits=1}" }, | ||
{ "src": "{0.12 :percent minimumSignificantDigits=1}" }, | ||
{ | ||
"src": "{$x :percent}", | ||
"params": [{ "name": "x", "value": 0.99 }] | ||
}, | ||
{ | ||
"src": ".input {$n :percent} .match $n one {{one}} * {{other}}", | ||
"params": [{ "name": "n", "value": 0.01 }], | ||
"exp": "one" | ||
}, | ||
{ | ||
"src": ".input {$n :percent} .match $n one {{one}} * {{other}}", | ||
"params": [{ "name": "n", "value": 1 }], | ||
"exp": "other" | ||
} | ||
] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.