This repository was archived by the owner on Nov 3, 2019. It is now read-only.
Scroll page instead of navigating#15
Open
tamlyn wants to merge 1 commit intounindented:masterfrom
Open
Conversation
This is because the isolated mode in RSG, which is used for getting the component URL, is not available when pagePerSection is true.
unindented
force-pushed
the
master
branch
2 times, most recently
from
8c80c44 to
4977af8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is because the isolated mode in RSG, which is used for getting the component URL, is not available when pagePerSection is true. See #14.
Needs more testing (like does it work with your conditional rendering component) but I'm just putting it out there as a possible fix.
Other approaches I tried:
data-previewname property (doesn't work because only the first isolated view for each section is accessible in RSG).