This repository was archived by the owner on Nov 3, 2019. It is now read-only.
Allow regex filter#5
Open
brettjurgens wants to merge 5 commits intounindented:masterfrom
Open
Conversation
Owner
|
Can you give an example where a glob expression is not enough? |
Author
|
@unindented as far as I can tell, globs will not let you do something like The issue I encountered that caused me to open this PR was that we have a spinner component that would not always be screenshotted in the correct position. Ignoring the image was the best solution |
unindented
force-pushed
the
master
branch
2 times, most recently
from
8c80c44 to
4977af8
Compare
|
This does not work for me. |
Owner
|
@khalidazam what doesn't work? The PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the 'filter' parameter to be a regular expression