feat(keyring): switch deriveContextHash to per-account-xpub semantics#5
Open
jrwbabylonlab wants to merge 2 commits intounisat-wallet:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
deriveContextHashIKM source from a fixed BIP-32 path(wallet-level) to the connected leaf's private key — the BIP-32 leaf
at the active receive-address path (e.g.
m/44'/0'/0'/0/0). HD andimported paths are now symmetric: one connected public key = one IKM =
one output.
Behavior change
dApps that need cross-leaf shared state (e.g. account-scoped data) must
do that aggregation themselves — they're connecting one address at a
time, so they get exactly one output per connection.
Breaking change is sanctioned by
@experimentalderiveContextHashis marked Experimental in the inpage method,type registry, API docs, doc index, and release notes. The API docs
explicitly tell integrators to use feature detection. Salt unchanged —
the IKM-source change alone produces independent outputs from v1.0.
Implementation note
The HD-keyring lookup matches the connected pubkey against the keyring's
existing leaf wallets and uses that leaf's private key directly as IKM.
No new BIP-32 derivation path; reuses whatever path the keyring is
already authorized for.
Spec updates: babylonlabs-io/babylon-toolkit#1540