Update lsp version and add cabal fixes #5148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is great thanks! Yeah if it's cool with you I'll try just pulling these commits into my other PR 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @ChrisPenner I noticed your PR #5142 wasn't compiling because of LSP so I re-added a change I made a while back. Hopefully this would now all pass 🤞 (edit: seems to pass on Ubuntu and Mac but not windows 🤔 ) Feel free to use this as you wish either fully or in part!
The main change is:
I've also added changes to get cabal to compile. But feel free to not include them.
Test coverage
Only local testing with
cabal-install version 3.10.3.0andghc-9.6.5Loose ends
N/A?