Pin Haskell tool versions for VS Code #5196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also has the flake get its version pins (when possible) from the VS Code settings. And we pin Cabal now, too.
sellout
commented
Jul 9, 2024
| "haskell.toolchain": { | ||
| "cabal": "3.10.3.0", | ||
| "hls": "2.8.0.0", | ||
| "stack": "2.15.7" |
Contributor
Author
There was a problem hiding this comment.
I wonder if VS Code or the extension will complain if we put the other version pins here, so they’re all in one place.
Or is that a bad idea because VS Code users might think that it’s actually pinning Ormolu, etc.
Contributor
Author
|
This is on top of the LTS upgrade (#5142). I don’t intend to merge it there, but just to block until that is merged. |
Contributor
Author
|
Well, that’s interesting … I guess I shouldn’t point a merge at a branch that might get deleted. |
Contributor
Author
|
Trying to re-point this at trunk now … |
Contributor
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help VS Code users get the same versions of various tools as Nix users do when working on Unison.
This also has the flake get its version pins from the VS Code settings. And we pin Cabal now, too.