Alipay Plus Connect samples #245
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spavikevik
suggested changes
Feb 1, 2022
spavikevik
left a comment
spavikevik
left a comment
There was a problem hiding this comment.
I took a brief look and commented on some things that caught my eye. It mostly looks good, but I'll have to take a look again tomorrow/after we decide how to deal with the problematic places on the api side.
| "data": { | ||
| "brand": "KAKAOPAY", | ||
| "call_method": "app", | ||
| "os_type": "i_os" |
There was a problem hiding this comment.
Suggested change
| "os_type": "i_os" | |
| "os_type": "ios" |
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "issuer_token" : "alipayconnect://schemeUrl", | |||
There was a problem hiding this comment.
Is it ok for this to be alipayconnect?
| "data": { | ||
| "brand": "KAKAOPAY", | ||
| "call_site" : "sdk", | ||
| "os_type" : "i_os" |
There was a problem hiding this comment.
Pls change to ios
Suggested change
| "os_type" : "i_os" | |
| "os_type" : "ios" |
Collaborator
Author
|
Still need some work, do not merge 😄 |
andrezimmermann
force-pushed
the
develop
branch
from
a59e2a1 to
2c67cab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
AlipayPlusOnlineITtestsCurrently it contains just the sdk usage for dynamic brands
Notable change is the change at OnlinePayment model
Had to refactor the brand from OnlineBrand to a String and add a method