[53] Allow selection of Unraid OS Language within the USB creator

[jlre249]

Closes #53

A few things to be aware of:

• For some reason, when using the regular DownloadThread to download the JSON and XML files, it automatically pads the files with extra null characters out to 1 MB. I suspect this has something to do with how the buffer is being written to file. I added a quick & dirty workaround for it, but it's possible we might want to look more into how DownloadThread is conducting its business.

• The unraid zip I was pulling didn't actually have anything in the dynamix.cfg, so the behavior right now is to add that 'locale=""' line if it wasn't found for replacement. Hopefully this is the behavior we want.

[elibosley]

@jlre249 is this good to review?

[elibosley]

We need to make sure we put this locale= block under the "[display]" section - you may want to use an XML parser to parse the file and add a new section, I believe that you may want to parse this as XML

#include <QDomDocument>
#include <QString>
#include <QDebug>

void addLocaleToDisplaySection(QString& dataText, const QString& unraidLangCode) {
    QDomDocument doc;
    QString errorMsg;
    int errorLine, errorColumn;

    // Load the dataText as an XML document
    if (!doc.setContent(dataText, &errorMsg, &errorLine, &errorColumn)) {
        qDebug() << "Error parsing XML at line" << errorLine << "column" << errorColumn << ":" << errorMsg;
        return;
    }

    // Find the [display] section
    QDomElement root = doc.documentElement(); // Get the root element
    QDomNodeList displaySections = root.elementsByTagName("display");

    if (!displaySections.isEmpty()) {
        QDomElement display = displaySections.at(0).toElement(); // Assuming only one [display] section

        if (!display.isNull()) {
            // Check if "locale" attribute exists
            if (display.hasAttribute("locale")) {
                display.setAttribute("locale", unraidLangCode);
            } else {
                // Add "locale" attribute if not present
                display.setAttribute("locale", unraidLangCode);
            }
        }
    } else {
        // Add a new [display] section with the locale attribute
        QDomElement newDisplay = doc.createElement("display");
        newDisplay.setAttribute("locale", unraidLangCode);
        root.appendChild(newDisplay);
    }

    // Convert the modified XML back to a string
    QString newXml;
    QTextStream stream(&newXml);
    doc.save(stream, 4); // Indent with 4 spaces
    dataText = newXml;
}

[elibosley]

@jlre249 - left a comment about your mechanism of parsing the display config. Let's change this to use a proper XML parser.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.