-
-
Notifications
You must be signed in to change notification settings - Fork 2
chore: release v1.6.4 #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
17f1a7f
to
707e15f
Compare
WalkthroughThis update finalizes the release of version 1.6.4 for the Changes
Possibly related PRs
Poem
π Recent review detailsConfiguration used: CodeRabbit UI β Files ignored due to path filters (1)
π Files selected for processing (3)
β Files skipped from review due to trivial changes (2)
π§ Files skipped from review as they are similar to previous changes (1)
β° Context from checks skipped due to timeout of 90000ms (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=======================================
Coverage 93.67% 93.67%
=======================================
Files 13 13
Lines 2844 2844
=======================================
Hits 2664 2664
Misses 180 180 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
CodSpeed Performance ReportMerging #87 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
β Files ignored due to path filters (1)
Cargo.lock
is excluded by!**/*.lock
π Files selected for processing (3)
CHANGELOG.md
(1 hunks)Cargo.toml
(1 hunks)npm/package.json
(1 hunks)
β° Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Benchmark
π Additional comments (4)
Cargo.toml (1)
7-7
: Version bump to 2.0.0 is correct.
Major version increment aligns with the semver policy for breaking changes.npm/package.json (1)
3-3
: Version updated to 2.0.0.
Matches the Cargo.toml bumpβgood consistency across package metadata.CHANGELOG.md (2)
11-11
: Bug Fixes section is formatted correctly.
The heading follows the Keep a Changelog guidelines and captures the DOS device path fix.
13-13
: Verify PR link and description.
Ensure the linked PR#455
correctly points to theunrs/unrs-resolver
repository and describes the DOS device path fix.
707e15f
to
c494a34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! π
Reviewed c494a34 in 36 seconds. Click for details.
- Reviewed
51
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
6
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with π or π to teach Ellipsis.
1. npm/package.json:2
- Draft comment:
The version bump to 1.6.4 is consistent with Cargo.toml. The napi configuration and other metadata appear correctly set. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
2. Cargo.toml:12
- Draft comment:
Consider removing the leading slashes in the include paths. They should be relative (e.g. "src" instead of "/src") so that Cargo properly identifies the intended files. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. npm/package.json:3
- Draft comment:
Version bump to 1.6.4 is consistent across files. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
4. CHANGELOG.md:64
- Draft comment:
Typo detected: 'pacakge.json' should be corrected to 'package.json' for clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. CHANGELOG.md:443
- Draft comment:
Typographical issue: The list entry "* (napi) release wasi build" appears to have a misplaced asterisk and parenthesis. Consider changing it to "- (napi) release wasi build" to maintain consistent formatting. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. npm/package.json:43
- Draft comment:
Typographical error: The target 'wasm32-wasip1-threads' may be a typo. If it's meant to be 'wasm32-wasi-threads', please correct it. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_cz3QHyR0nLLmO6VU
You can customize by changing your verbosity settings, reacting with π or π, replying to comments, or adding code review rules.
|
π€ New release
unrs_resolver
: 1.6.3 -> 1.6.4β
unrs_resolver
breaking changesChangelog
This PR was generated with release-plz.
Important
Bump
unrs_resolver
version to 1.6.4 with a bug fix for DOS device path handling.unrs_resolver
version from 1.6.3 to 1.6.4 inCargo.toml
,Cargo.lock
, andnpm/package.json
.strip_windows_prefix
as noted inCHANGELOG.md
.This description was created by
for c494a34. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit