Make updating FlagPole's source list thread-safe. #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… method that takes a closure
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Description
Vexil 2 allowed direct manipulation of its source's via the setter on the
_sourcesproperty. This was no thread safe since it involved a read, manipulation of a local copy, and then setting it. It also meant multiple step operations like finding + removing an existingFlagValueSourceand replacing it would call thedidSetobserver multiple times if not careful, resulting in unnecessary snapshots and publishing.This PR removes the direct setter in favour of an
updateSourcesmethod that takes a closure and is passed a mutable copy of the sources array, which can be safely manipulated within the closer before being saved back again, and only one observer triggered.