-
Notifications
You must be signed in to change notification settings - Fork 0
feat(catalogue): add public collections endpoint api #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RaymondC-tech
wants to merge
10
commits into
main
Choose a base branch
from
feature/public-catalogue-endpoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+567
−89
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
07b7c8c
feat(catalogue): add pulblic collection item serializer
RaymondC-tech eaf0677
feat(catalogue): added viewset for collection items
RaymondC-tech 1b0edbf
feat(catalogue): added url routing to public collection catalogue
RaymondC-tech 7b49aaf
Merge remote-tracking branch 'origin/main' into feature/public-catalo…
RaymondC-tech 155d7e5
feat(catalogue): added unit tests for endpoints
RaymondC-tech da324d1
feat(catalogue): fix formating for code
RaymondC-tech 539c5d5
feat(catalogue): edited backemd yml file to use github actions secret…
RaymondC-tech 0ec5167
feat(catalogue): edited duplicated queryset initialization with the u…
RaymondC-tech 09b535b
feat(catalogue): removed redundant logic and edited unit tests
RaymondC-tech 0d1bbf5
feat(catalogue): fix formating code for tests
RaymondC-tech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,46 @@ | ||
| from rest_framework import serializers | ||
| from .models import CollectionItem, Location | ||
|
|
||
| # from .models import InventoryItem | ||
|
|
||
| # Create your serializers here. | ||
|
|
||
| # Example: InventoryItem Serializer | ||
| # Uncomment and modify as needed | ||
| # | ||
| # class InventoryItemSerializer(serializers.ModelSerializer): | ||
| # """ | ||
| # Serializer for the InventoryItem model. | ||
| # Handles conversion between model instances and JSON. | ||
| # """ | ||
| # created_by_username = serializers.CharField(source='created_by.username', read_only=True) | ||
| # | ||
| # class Meta: | ||
| # model = InventoryItem | ||
| # fields = '__all__' # Or specify: ['id', 'name', 'quantity', ...] | ||
| # read_only_fields = ['id', 'created_at', 'updated_at', 'created_by'] | ||
| # | ||
| # def validate_quantity(self, value): | ||
| # """Custom validation for quantity field.""" | ||
| # if value < 0: | ||
| # raise serializers.ValidationError("Quantity cannot be negative.") | ||
| # return value | ||
|
|
||
| class LocationSerializer(serializers.ModelSerializer): | ||
| """ | ||
| Nested serializer for Location model. | ||
| Used to show location details in public API responses. | ||
| """ | ||
|
|
||
| location_type_display = serializers.CharField(source="get_location_type_display", read_only=True) | ||
|
|
||
| class Meta: | ||
| model = Location | ||
| fields = ["id", "name", "location_type", "location_type_display", "description"] | ||
| read_only_fields = ["id", "name", "location_type", "location_type_display", "description"] | ||
|
|
||
|
|
||
| class PublicCollectionItemSerializer(serializers.ModelSerializer): | ||
| """ | ||
| Serializer for public-facing collection items. | ||
| Exposes read-only collection data without internal fields. | ||
| """ | ||
|
|
||
| current_location = LocationSerializer(read_only=True) | ||
|
|
||
| class Meta: | ||
| model = CollectionItem | ||
| fields = [ | ||
| "id", | ||
| "item_code", | ||
| "title", | ||
| "platform", | ||
| "description", | ||
| "is_on_floor", | ||
| "current_location", | ||
| ] | ||
| read_only_fields = [ | ||
| "id", | ||
| "item_code", | ||
| "title", | ||
| "platform", | ||
| "description", | ||
| "is_on_floor", | ||
| "current_location", | ||
| ] | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.