-
Notifications
You must be signed in to change notification settings - Fork 0
Add more linting rules and typecheck to the CI #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances code quality by adding stricter TypeScript configuration, additional ESLint rules, and automated checks in CI. The changes enforce explicit return types, enable comprehensive TypeScript strict mode checks, and add pre-commit hooks using husky and lint-staged.
Key changes:
- Enabled TypeScript strict mode with additional safety checks (noUncheckedIndexedAccess, noUnusedLocals, etc.)
- Added ESLint rules for explicit function return types and padding between functions
- Introduced husky and lint-staged for pre-commit quality checks
- Added GitHub Actions CI workflow for automated testing, linting, formatting, and typechecking
Reviewed changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Enabled strict mode and additional TypeScript compiler safety checks, restricted includes to src/ and tests/ directories |
| src/lib/client/supabase/server.ts | Updated to use bracket notation for process.env access (required by noPropertyAccessFromIndexSignature) |
| src/lib/api/getExample.ts | Added explicit return type annotation and updated import path to use index export |
| src/app/page.tsx | Added explicit return type annotation for Home component |
| src/app/layout.tsx | Added explicit return type annotation for RootLayout component |
| package.json | Added husky and lint-staged dependencies, updated scripts for typecheck and combined check/fix commands |
| package-lock.json | Updated lock file with new dependencies and removed unused peer dependencies |
| eslint.config.mjs | Added rules for explicit function return types and padding between functions |
| .lintstagedrc.mts | New lint-staged configuration for pre-commit hooks |
| .husky/pre-commit | New pre-commit hook script |
| .gitignore | Added .claude directory exclusion |
| .github/workflows/ci.yml | New CI workflow for automated checks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
51101c3 to
b220207
Compare
b220207 to
a69fcd4
Compare
a69fcd4 to
88594d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 9 out of 12 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
88594d0 to
88ef0b2
Compare
Fixes #40
TLDR
Added stricter linting rules, TypeScript typecheck, pre-commit hooks, and a GitHub action to ensure code quality.
What changed?