Skip to content

Implement local testing with supabase #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ch-iv wants to merge 1 commit into from
Closed

Implement local testing with supabase #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ jobs:
- name: Install dependencies
run: npm install

- name: Start the database
run: npm run db

- name: Run tests
run: npm test

Comment on lines +27 to 31
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The npm run db command will fail in the CI environment because:

  1. It uses rm .env which is not cross-platform (GitHub Actions can run on Windows)
  2. The command doesn't check if Supabase is already running
  3. There's no cleanup of the Supabase instance after tests complete, which could leave resources running

Consider:

  1. Using npx supabase stop in a cleanup step
  2. Handling the cross-platform file removal issue
  3. Adding error handling for the database startup
Suggested change
run: npm run db
- name: Run tests
run: npm test
run: npm run db || exit 1
- name: Run tests
run: npm test
- name: Stop Supabase (cleanup)
run: npx supabase stop
if: always()

Copilot uses AI. Check for mistakes.
Expand Down
2 changes: 1 addition & 1 deletion .vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"recommendations": ["dbaeumer.vscode-eslint", "esbenp.prettier-vscode"]
"recommendations": ["denoland.vscode-deno"]
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VS Code recommended extensions were replaced, removing ESLint and Prettier extensions and adding only Deno. However, the project still uses ESLint and Prettier (based on package.json and other config files). The Deno extension is only needed for supabase/functions directory. Consider keeping the ESLint and Prettier extensions in the recommendations alongside Deno, as they're still actively used in this project.

Suggested change
"recommendations": ["denoland.vscode-deno"]
"recommendations": [
"denoland.vscode-deno",
"dbaeumer.vscode-eslint",
"esbenp.prettier-vscode"
]

Copilot uses AI. Check for mistakes.
}
24 changes: 22 additions & 2 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,26 @@
{
"editor.formatOnSave": true,
"[typescript]": {
"editor.defaultFormatter": "denoland.vscode-deno"
},
Comment on lines +2 to +4
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TypeScript default formatter is set to Deno for all TypeScript files, but Deno should only be used for files in supabase/functions (as configured in line 5). This will cause formatting inconsistencies since the rest of the codebase uses Prettier. Consider either:

  1. Removing this global TypeScript formatter override and letting it default to Prettier
  2. Using a more specific configuration that only applies Deno formatting to files within supabase/functions
Suggested change
"[typescript]": {
"editor.defaultFormatter": "denoland.vscode-deno"
},

Copilot uses AI. Check for mistakes.
"deno.enablePaths": ["supabase/functions"],
"deno.lint": true,
"deno.unstable": [
"bare-node-builtins",
"byonm",
"sloppy-imports",
"unsafe-proto",
"webgpu",
"broadcast-channel",
"worker-options",
"cron",
"kv",
"ffi",
"fs",
"http",
"net"
],
"editor.codeActionsOnSave": {
"source.fixAll.eslint": "always"
}
},
"editor.formatOnSave": true
}
Loading