Alexlewis/intl 17 for students page skeleton #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlewis9
force-pushed
the
alexlewis/intl-17-for-students-page-skeleton
branch
from
cefa27b to
e1afc0f
Compare
…//github.com/uoftblueprint/website-v2 into alexlewis/intl-17-for-students-page-skeleton
aya-en-amir
reviewed
Nov 20, 2024
Contributor
aya-en-amir
left a comment
aya-en-amir
left a comment
There was a problem hiding this comment.
Looks good to me. Minor comment: increasing the width of the role card would match the design more accurately. Otherwise all good!
Member
jordanjanakievski
left a comment
jordanjanakievski
left a comment
There was a problem hiding this comment.
Left a few comments, just some things that I noticed while playing with the page. Everything is looking really great tho
jordanjanakievski
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/uoft-blueprint-internal/issue/INTL-17/for-students-page-skeleton
https://linear.app/uoft-blueprint-internal/issue/INTL-24/for-students-page-header
https://linear.app/uoft-blueprint-internal/issue/INTL-25/for-students-page-alumni-companies
https://linear.app/uoft-blueprint-internal/issue/INTL-26/for-students-page-hiring-section
https://linear.app/uoft-blueprint-internal/issue/INTL-28/for-students-page-faq