Bug - Chapter Cards Not Responsive #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlewis9
reviewed
Nov 27, 2024
Contributor
alexlewis9
left a comment
alexlewis9
left a comment
There was a problem hiding this comment.
Responsiveness is good. I think it would be nice if all the cards were the same height. Also the text spaceing is a bit weird on a smaller window.
Contributor
|
Also Canada and USA are not aligned the same.
|
jordanjanakievski
approved these changes
Nov 28, 2024
Member
jordanjanakievski
left a comment
jordanjanakievski
left a comment
There was a problem hiding this comment.
Looks great. Love how they look all uniform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/uoft-blueprint-internal/issue/INTL-36/bug-chapter-cards-not-responsive
Chapters page is now using SimpleGrid + is responsive.