deps!: bump major dependencies for Hacktoberfest 2025#148
deps!: bump major dependencies for Hacktoberfest 2025#148ehrelevant merged 27 commits intoup-csi:mainfrom
Conversation
There was a problem hiding this comment.
Thank you for the PR! The updated linting rules are much appreciated, and I more or less agree with all the rules that were explicitly set. Just have a couple of nitpicks that should improve cleanliness some more. Some of my comments are also directed towards @galierie, who maintained this codebase last semester and should be more familiar with it than me.
So far as components go, I do agree we will need a rewrite eventually. I also noticed a lot of weird components and some parts that had strange typing (some of which is my fault 💀). That said, I'd prefer if we complete and fix up this version of the website with handwritten components before we attempt a rewrite, since it's almost fully functional (even if it's mostly a result of black magic).
Co-Authored-By: Ehren Castillo <ehrencastillo@gmail.com>
Co-Authored-By: Ehren Castillo <ehrencastillo@gmail.com>
|
Thanks for the comments @ehrelevant. A lot of the code nitpicks are due to pre-existing code that I omitted migrating over out of an abundance of caution to the existing logic. We can have a separate ticket for the actual cleanup of these components. |
ehrelevant
left a comment
There was a problem hiding this comment.
That's fair enough, but I agree that we should put up a ticket for that. For now, let's wait for @galierie's comments, but on my end, it LGTM!!!
ca94445 to
69f1c91
Compare
|
Hello! Sorry for the delay on this. I'll go ahead with merging this PR without @galierie's review (with their consent) since this has stalled for a bit too long. Rather than holding this back for longer, we'll just review these changes again at a later date and create a PR for any revisions deemed necessary. In any case, thank you again for this contribution @BastiDood! |
|
Additionally, on this note:
In retrospect, I think I'm not actually in favor of replacing the website's handwritten components with |
Hello all! As part of my yearly contribution to UP CSI for Hacktoberfest 2025, I present this year's edition of major dependency bumps. As always, all of the updated practices hail from my SvelteKit template. Feel free to disagree with some of the lints, and I'd gladly remove them if necessary.
List of Refactors
pnpm/action-setupandactions/setup-nodefor setting up the dependency cache. No need for us to implement our own bespoke version for this.eslint.config.jsto be in line with my template. Some rules have been added; some have been removed; feel free to request changes on these.pnpmfrom10.8.0to10.18.0.eachblocks without keys, navigation links lackingresolve, and general code cleanliness.Future Work
A lot of components need a rewrite. Specifically, I recommend that we scrap our handwritten components to using
shadcn-svelte(or any of your favorite libraries!) instead. I saw a lot of black magics during my refactors. 😅