Skip to content

Conversation

@olxmpe
Copy link
Contributor

@olxmpe olxmpe commented Oct 27, 2025

What does this PR do?

When a column is ordered, trigger an 'apply-order' event

Related to : #

What are the observable changes?

πŸ§‘β€πŸ’» Developer Heads Up

⚑ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

Additional Notes

@olxmpe olxmpe self-assigned this Oct 27, 2025
@olxmpe olxmpe requested review from a team and phndiaye as code owners October 27, 2025 09:41
@linear
Copy link

linear bot commented Oct 27, 2025

@olxmpe olxmpe requested review from Elodie-DeMatteis-Upf and OwenCoogan and removed request for a team October 27, 2025 09:41
Copy link
Contributor

@JulienVannier66 JulienVannier66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@olxmpe olxmpe merged commit 3a7c2f4 into master Oct 28, 2025
3 checks passed
@olxmpe olxmpe deleted the ol/vel-6476 branch October 28, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants