.: Add a multi incarnation scope wrapper #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexisMontagne
requested review from
FlorianRichardUPF and
Sypheos
and removed request for
a team
AlexisMontagne
force-pushed
the
am/multi-incaration
branch
from
1b710da to
87c87e9
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return micv.cv.WithLabels( | ||
| append( | ||
| vs, | ||
| strconv.Itoa(int(micv.registry.next(ck))), |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
G115: integer overflow conversion uint -> int (gosec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In an effort to find potential contention in our infrastructure i have been instrumenting different pools (connection pool to the DB, thrift client pool...).
One issue arise in that kind of scenario, if there is multiple pool with similar labels it makes the data worth less to be analyzed.
This
stats.Scopewrapper automatically add aincarnationlabel that is incremented. So if two connection pool to the DB are opened metrics for both will be reported independently.What are the observable changes?
Good PR checklist
Additional Notes