Skip to content

Update release workflow to use trusted publishing #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
risantos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update release workflow to use trusted publishing #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,20 @@ jobs:
concurrency:
group: release-${{ github.repository }}-${{ github.ref_name }}
cancel-in-progress: false
permissions:
contents: write
id-token: write

steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
persist-credentials: false

- name: Setup Node.js version
uses: actions/setup-node@v4
uses: actions/setup-node@v6
with:
node-version: 22
node-version: 24
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Node.js version has been upgraded from 22 to 24. Note that Node.js 24 is currently in active development and may not be a stable LTS release. Verify that all project dependencies and build tools are compatible with Node.js 24, or consider using Node.js 22 (the current LTS) if Node.js 24 compatibility is not required.

Suggested change
node-version: 24
node-version: 22

Copilot uses AI. Check for mistakes.

- name: Install dependencies
run: yarn install --frozen-lockfile
Expand All @@ -41,9 +44,6 @@ jobs:
git config user.email "bot@uphold.com"
git config --global url.https://${{ secrets.RELEASE_GITHUB_TOKEN }}@github.com/.insteadOf https://github.com/

- name: Configure npm
run: npm config set //registry.npmjs.org/:_authToken ${{ secrets.RELEASE_NPM_TOKEN }}

- name: Generate release
env:
GITHUB_TOKEN: ${{ secrets.RELEASE_GITHUB_TOKEN }}
Expand Down
3 changes: 2 additions & 1 deletion .release-it.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ module.exports = {
]
},
npm: {
publish: true
publish: true,
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skipChecks option is set to true without documentation explaining why this is necessary for OIDC publishing. This bypasses important pre-publish validations. Consider documenting the reason for this change in a comment, or verify if this option is actually required for trusted publishing to work.

Suggested change
publish: true,
publish: true,
// NOTE: `skipChecks` is intentionally enabled because npm's local credential
// and 2FA checks are incompatible with our CI-based OIDC/trusted publishing
// workflow. Release validation and authorization are enforced by the
// GitHub Actions pipeline rather than via `npm publish` pre-checks.

Copilot uses AI. Check for mistakes.
skipChecks: true
}
};
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,13 @@
"isoc": "0.0.1",
"moment": "^2.30.1",
"prettier": "^3.5.3",
"release-it": "^19.0.3",
"release-it": "^19.2.3",
"tin-validator": "^1.1.0",
"uk-modulus-checking": "0.0.3",
"urijs": "^1.17.1",
"validate-rfc": "^2.0.3",
"validator.js": "^2.0.0",
"validator": "^13.15.15"
"validator": "^13.15.15",
"validator.js": "^2.0.0"
},
"peerDependencies": {
"abavalidator": "^2.0.0",
Expand All @@ -86,8 +86,8 @@
"uk-modulus-checking": "^0.0.2",
"urijs": "^1.0.0",
"validate-rfc": "^2.0.3",
"validator.js": "^2.0.0",
"validator": ">=3 <14"
"validator": ">=3 <14",
"validator.js": "^2.0.0"
},
"peerDependenciesMeta": {
"abavalidator": {
Expand Down
Loading
Loading