feat: add support for Dataview tasks#209
feat: add support for Dataview tasks#2098bitbuddhist wants to merge 8 commits intouphy:masterfrom 8bitbuddhist:dataview-support
Conversation
|
ref: #147 |
It seems that this task title contains unexpected characters 
|
| get dateTrigger() { | ||
| return this.get("date-trigger", "due:: "); | ||
| } | ||
|
|
||
| get dateFormat() { | ||
| return this.get("date-format", "YYYY-MM-DD"); | ||
| } | ||
|
|
||
| get timeTrigger() { | ||
| return this.get("time-trigger", "time:: "); | ||
| } | ||
|
|
||
| get timeFormat() { | ||
| return this.get("time-format", "HH:mm"); | ||
| } | ||
|
|
||
| get linkDateToDailyNote() { | ||
| return this.get("link-date-to-daily-note", false); | ||
| } |
There was a problem hiding this comment.
I couldn't find these settings from Dataview plugin.
Are these settings correct?
There was a problem hiding this comment.
If there are no such settings in Dataview plugin, I feel we need these settings in obsidian-reminder plugin.
There was a problem hiding this comment.
due is part of the shorthand syntax Dataview supports for tasks. I couldn't find a property built into Dataview specifically for tracking completion dates, but they use shorthand fields in their examples, so I think it's ok to include.
For time, there isn't a field like this in Dataview, but it's technically possible to track times using properties. I thought it would be better to include a time field as an option, but it might be better to wait until it's officially supported by the Tasks plugin first.
There was a problem hiding this comment.
Thank you for the explanation.
This code likely references my Kanban integration code. The original code retrieves the Kanban plugin's settings object and adjusts the reminder plugin's behavior to match the Kanban plugin.
However, this Dataview integration code references a setting that doesn't actually exist, so it always defaults and is meaningless.
As mentioned above, a new setting likely needs to be created for the obsidian-reminder plugin.
2 participants
This PR adds support for tasks formatted using Dataview. It supports
[due:: YYYY-MM-DD]and[time:: HH:mm]fields. It also supports daily note links (e.g.[due:: [[2024-12-13]]]).