Add + [] format as a valid Todo format#260
Open
ljbkusters wants to merge 1 commit intouphy:masterfrom
Open
Conversation
Add missing `+ []` format as a valid Todo format by changing the regex in the Todo class. This is fixed by adding `+` as a valid prefix character in the regex. fixes uphy#259
Author
|
Since I'm unsure on how to build this project I was unable to validate that this PR fixes #259 I was able to validate the following regex matches on regex101.com 
Hence I'm assuming this should fix the issue described in #259. I think it's a good idea to validate this. I would be willing to validate myself if you could give me some documentation on how to build the project and install it locally. Otherwise you may want to try for yourself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing
+ []format as a valid Todo format by changing the regex in the Todo class.This is fixed by adding
+as a valid prefix character in the regex.fixes #259