Skip to content

Conversation

@vtnate
Copy link
Contributor

@vtnate vtnate commented Nov 12, 2024

Resolves #[issue number here]

Pull Request Description

  • Use a new version of miniconda. The previous version had an older version of pip included which couldn't handle new python packaging standards. This resolves that issue.
  • Use a new version of ThermalNetwork, to resolve the failing tests.

Since we set up miniconda, they have switched to date-version format, instead of semantic-version.

Checklist (Delete lines that don't apply)

  • Unit tests have been added or updated
  • All ci tests pass (green)
  • An issue has been created (which will be used for the changelog)
  • This branch is up-to-date with develop

@vtnate vtnate requested a review from kflemin November 12, 2024 21:58
@kflemin
Copy link
Contributor

kflemin commented Nov 12, 2024

@tanushree04, would you be able to test this on our windows machine? clearing out your python dependencies, running "bundle exec uo install_python" would be great!

Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! i'd like to get the tests that were canceled to run before we merge this PR in though. especially the electric ones.

@tanushree04
Copy link
Contributor

The command works!

I see some warnings while installing but i think they can be suppressed if needed.

Error installing: WARNING: The script pygmentize.exe is installed in 'C:\urbanopt-cli\example_files\python_deps\python-3.10\Scripts' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
WARNING: The script f2py.exe is installed in 'C:\urbanopt-cli\example_files\python_deps\python-3.10\Scripts' which is not on PATH.
Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.

@kflemin
Copy link
Contributor

kflemin commented Nov 12, 2024

agreed, I think those can be ignored. thanks for checking!!

@vtnate vtnate self-assigned this Nov 13, 2024
@vtnate vtnate added enhancement New feature or request dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Nov 13, 2024
@vtnate vtnate merged commit 3a43eec into develop Nov 13, 2024
5 checks passed
@vtnate vtnate deleted the upgrade-miniconda branch November 13, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants