Additional API method and critical ElectRS bug#31
Open
cyclomancer wants to merge 3 commits intourbit:masterfrom
Open
Additional API method and critical ElectRS bug#31cyclomancer wants to merge 3 commits intourbit:masterfrom
cyclomancer wants to merge 3 commits intourbit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked PR to
urbit/urbitgetblocktxsmethod to fetch complete list of raw transactions by blockhash%volt, Urbit's Lightning implementation, needs to find and categorize a transaction spending one of its channels as cooperative, forced, or malicious, and in the last case match the raw transaction to a specific revocation signature. Compared to alternative solutions (modifying the existinggetblockinfostructure, fetching the entire raw block and parsing it on the Hoon side, or fetching verbose transaction JSON) this has no impact on existing usage, a small code footprint, and provides functionality that will also be useful for future Bitcoin use-cases other than Lightning.As of now, ships running
%btc-providerwith a mainnet full node will have stopped indexing new blocks at height 761248 unless they manually updated ElectRS and restarted the proxy server.