manage: new bail code, remove traps if discarding cold state#974
Open
dozreg-toplud wants to merge 2 commits intodevelopfrom
Open
manage: new bail code, remove traps if discarding cold state#974dozreg-toplud wants to merge 2 commits intodevelopfrom
dozreg-toplud wants to merge 2 commits intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #940 we prevented promoting potentially incorrect HAMTs by discarding them on non-deterministic errors. Recently @yosoyubik noticed that failing migrations spin forever without printing the trace.
We found out that the issue was caused by the
(trap tank)nouns in the stacktrace: these thunks outlived the cold state that was nececcary to run them, causing+mookto spin forever.This PR addresses two issues:
5that represents the latter. On5we rebail with the same code, just like it worked previously with3. On3we rebail with5, discarding the road state.3we replace[%mean (trap tank)]elements of the stack trace with[%mean '####']. We do the same with the innermost road when we unwind the road stack on an incoming signal. That way we won't later run computations that will require the cold state that we discarded.