Skip to content

flag: replace regexp use#2288

Merged
dearchap merged 1 commit intourfave:mainfrom
kolyshkin:no-regexp
Mar 21, 2026
Merged

flag: replace regexp use#2288
dearchap merged 1 commit intourfave:mainfrom
kolyshkin:no-regexp

Conversation

@kolyshkin
Copy link
Copy Markdown
Contributor

What type of PR is this?

  • cleanup

What this PR does / why we need it:

Commit ec05a8d introduces the only (non-test) user of regexp package.
It is pretty easy to not use regexp here, so let's get rid of it.

References:

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Testing

Assuming existing tests cover the change.

Release Notes

Remove regexp dependency.

@kolyshkin
Copy link
Copy Markdown
Contributor Author

@dearchap PTAL

@dearchap
Copy link
Copy Markdown
Contributor

@kolyshkin can you resolve the conflicts ?

Commit ec05a8d introduces the only (non-test) user of regexp package.
It is pretty easy to not use regexp here, so let's get rid of it.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@abitrolly
Copy link
Copy Markdown
Contributor

 		// v1 -> v2 migration warning zone:
		// Strip off anything after the first found comma or space, which
		// *hopefully* makes it a tiny bit more obvious that unexpected behavior is
		// caused by using the v1 form of stringly typed "Name".

What all this comment is about? Is it still actual for v3?

@dearchap
Copy link
Copy Markdown
Contributor

@abitrolly yes. Still valid.

@dearchap dearchap merged commit 58e99ee into urfave:main Mar 21, 2026
9 checks passed
@abitrolly
Copy link
Copy Markdown
Contributor

@kolyshkin how did you trace size changes? Perhaps we could use a CI/CD bot to evaluate PRs.

@kolyshkin
Copy link
Copy Markdown
Contributor Author

@kolyshkin how did you trace size changes?

See opencontainers/runc#5184 (comment) (about 500K)

@kolyshkin kolyshkin deleted the no-regexp branch March 22, 2026 18:25
Maks1mS pushed a commit to stplr-dev/stplr that referenced this pull request Mar 28, 2026
This PR contains the following updates:

| Package | Type | Update | Change | OpenSSF |
|---|---|---|---|---|
| [github.com/urfave/cli/v3](https://github.com/urfave/cli) | require | minor | `v3.7.0` → `v3.8.0` | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/urfave/cli/badge)](https://securityscorecards.dev/viewer/?uri=github.com/urfave/cli) |

---

> ⚠️ **Warning**
>
> Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/23) for more information.

---

### Release Notes

<details>
<summary>urfave/cli (github.com/urfave/cli/v3)</summary>

### [`v3.8.0`](https://github.com/urfave/cli/releases/tag/v3.8.0)

[Compare Source](urfave/cli@v3.7.0...v3.8.0)

#### What's Changed

- chore(deps): bump mkdocs-material from 9.7.1 to 9.7.2 in the python-packages group by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2267](urfave/cli#2267)
- chore(deps): bump mkdocs-material from 9.7.2 to 9.7.3 in the python-packages group by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2272](urfave/cli#2272)
- chore(deps): bump mkdocs-material from 9.7.3 to 9.7.4 in the python-packages group by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2276](urfave/cli#2276)
- Fix: check MutuallyExclusiveFlags across parent command chain by [@&#8203;siutsin](https://github.com/siutsin) in [#&#8203;2274](urfave/cli#2274)
- Modernize source code by [@&#8203;kolyshkin](https://github.com/kolyshkin) in [#&#8203;2289](urfave/cli#2289)
- flag: replace regexp use by [@&#8203;kolyshkin](https://github.com/kolyshkin) in [#&#8203;2288](urfave/cli#2288)
- chore(deps): bump mkdocs-material from 9.7.4 to 9.7.5 in the python-packages group by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;2284](urfave/cli#2284)
- Fix:(issue\_2281) Remove incorrect check for local flag for set by [@&#8203;dearchap](https://github.com/dearchap) in [#&#8203;2290](urfave/cli#2290)
- Fix:(issue\_2275) Make flag action execution consistent by [@&#8203;dearchap](https://github.com/dearchap) in [#&#8203;2295](urfave/cli#2295)
- Fix:(issue\_2293) --flag="" no longer rejected as missing argument by [@&#8203;idelchi](https://github.com/idelchi) in [#&#8203;2297](urfave/cli#2297)
- Fix:(issue\_2292) Empty positional args no longer break parse loop by [@&#8203;idelchi](https://github.com/idelchi) in [#&#8203;2296](urfave/cli#2296)

#### New Contributors

- [@&#8203;idelchi](https://github.com/idelchi) made their first contribution in [#&#8203;2297](urfave/cli#2297)

**Full Changelog**: <urfave/cli@v3.7.0...v3.8.0>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At 12:00 AM through 04:59 AM and 10:00 PM through 11:59 PM, Monday through Friday ( * 0-4,22-23 * * 1-5 ), Only on Sunday and Saturday ( * * * * 0,6 ) (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My44Ni4xIiwidXBkYXRlZEluVmVyIjoiNDMuODYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiS2luZC9EZXBlbmRlbmNpZXMiXX0=-->

Reviewed-on: https://altlinux.space/stapler/stplr/pulls/376
Co-authored-by: Renovate Bot <stapler-helper-bot@noreply.altlinux.space>
Co-committed-by: Renovate Bot <stapler-helper-bot@noreply.altlinux.space>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants