Skip to content

Conversation

@techbrew-mc
Copy link

I also recommend renaming the repo to "twitch-api-wrapper" to keep consistent with the artifact name.

These changes work nicely with jitpack.io as well: https://jitpack.io/#techbrew-mc/twitch-api-wrapper/0.3.1
(That makes it easy to integrate into other projects without having your releases in Maven Central.)

@Gikkman
Copy link

Gikkman commented Jan 31, 2017

JitPack can be used with any GitHub release, given that it is configured correctly, so it is not necessary to move to Gradle for that reason alone.

I guess acceptance this pull request will depend on whether @urgrue uses Gradle in his development setup or not. Did you see #20 ?

@techbrew-mc
Copy link
Author

I didn't see #20, but I did see the roadmap mention of Gradle.

Moreover, the existing maven build doesn't work in jitpack, so perhaps fixing that would be the better compromise:

https://jitpack.io/com/github/urgrue/Java-Twitch-Api-Wrapper/0.3/build.log

@Gikkman
Copy link

Gikkman commented Feb 1, 2017

You're right, it doesn't work with JitPack... I really thought it did... That is definitely something we should strive to fix then.

@SamboyCoding
Copy link

I've fixed the maven build in #27, just waiting on approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants