-
Notifications
You must be signed in to change notification settings - Fork 77
📚 Improve schema docs #1554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📚 Improve schema docs #1554
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1554 +/- ##
==========================================
+ Coverage 86.87% 87.95% +1.07%
==========================================
Files 56 70 +14
Lines 6532 9606 +3074
==========================================
+ Hits 5675 8449 +2774
- Misses 857 1157 +300
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@MrChocolateMoose I'd appreciate your feedback on the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a quick scan through, looks all good
|
I started reviewing this AM, but should be finished by the end of my day. |
|
Thanks. Will wait with the merge until tomorrow. |
6409d6a to
c1051a7
Compare
|
I looked at the rendered docs and it looks good to me as well. It addresses my checklist of points I wrote. I had a few side points that depending on the answer could warrant updates to the schema docs (e.g. some confusion on why I would set an enum value on the need field and as a validation schema, no mention of global regex options being disallowed). #1543 and #1536 No need to hold the PR up though. I approve. |
Fixes #1542 and #1539.