fix: normalize certificate paths in collection export and import #4964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdeboyeDN
requested review from
helloanoop,
maintainer-bruno,
lohit-bruno and
naman-bruno
as code owners
pietrygamat
suggested changes
Jun 23, 2025
Comment on lines
14
to
16
| export function normalizePath(p) { | ||
| return p ? p.replace(/\\\\|\\/g, '/') : p; | ||
| } |
There was a problem hiding this comment.
Hi, I just pushed an update. Kindly review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #4869 (Path is not OS safe)
Added a normalizePath utility to ensure all certificate file paths in collections use forward slashes (/), making them OS-safe and cross-platform.
Applied normalizePath during collection export to prevent new exports from containing OS-specific paths (e.g., Windows backslashes).
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.