fix(onboarding): restore user state on warm start#71
Open
acslater00 wants to merge 1 commit intomasterfrom
Open
fix(onboarding): restore user state on warm start#71acslater00 wants to merge 1 commit intomasterfrom
acslater00 wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PreflightResolvedinto bootstrap state so sync completion can transition to chatWhy
Warm starts could reach PowerSync
Readyand then stall in onboarding. The root cause was that the fresh auth path populatedbootstrap.State.User, but the preflight path only restored auth validity plus org/account state. After sync completed, onboarding rejected completion becauseUserwas still nil.Implementation details
bootstrap.PreflightStatewith an optionalUserGetUserID()after validating the access token and attach a minimalauth.User{ID: ...}ApplyPreflightto copy that user into bootstrap statePreflightResolvedcarries user state forwardVerification
sync completed without required onboarding state has_user=false ...go testwas not runnable in this environment because the sandbox could not reachproxy.golang.orgto fetch modulesRisk
auth.Useris populated minimally withIDbecause warm-start completion only requires presence of the user object