Slicing out of bound modification#2588
Merged
DavyLandman merged 2 commits intousethesource:mainfrom Jan 8, 2026
Merged
Conversation
jbdoderlein
commented
Jan 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2588 +/- ##
=======================================
Coverage 46% 46%
+ Complexity 6628 6624 -4
=======================================
Files 793 793
Lines 65586 65590 +4
Branches 9823 9824 +1
=======================================
+ Hits 30477 30487 +10
+ Misses 32753 32750 -3
+ Partials 2356 2353 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jbdoderlein
commented
Jan 8, 2026
PaulKlint
approved these changes
Jan 8, 2026
Member
PaulKlint
left a comment
There was a problem hiding this comment.
I think this refinement looks good. Thanks for fixing this and also for including test cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is linked to this issue
The documentation change is defined in this PR
This change allow the slicing to be out of bound and work with negative index.
With
L = [0,1,2,3,4,5,6,7,8,9];:L[..-11][][1]L[10..-5][9,8,7,6]L[-11..][0,1,2,3,4,5,6,7,8,9]Fixes #2370