Native logical locs #33
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides most comparison operations on locations with extra map arguments that maps logical locations to physical ones.
- During the collect phase logical locations are computed and collected in a map - All information in TModels that is added via addTModel is remembered. Note that info is already based on logical locations. - At the end of the collect phase, all information gathered (excluded that from added TModels) is converted to logical locations, except locations in error messages.
Both functions work as the standard ones, but take the current logical to physical mapping into account.
- Implemented isContainedIn and isBefore - Make sure that all locations entering via the Solver API are first converted to logical form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use logical locations more deeply in TypePal, see commit comments for details.