This repository was archived by the owner on Jun 15, 2018. It is now read-only.
Expand cluster testcase #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltrilety
reviewed
Mar 13, 2018
| From one of already imported hosts run: | ||
| ``gluster peer probe [new_host]`` | ||
| where ``[new_host]`` is host that is going to be used to expand cluster. | ||
| Repeat for all new hosts. |
Contributor
There was a problem hiding this comment.
I would think about to do some work with volumes too. E.g. create a new one on all nodes or expand existing one etc.
Contributor
There was a problem hiding this comment.
True, but that could be covered in another test case.
mbukatov
reviewed
Jun 1, 2018
Contributor
mbukatov
left a comment
mbukatov
left a comment
There was a problem hiding this comment.
Looks good, now I need to check if the current description matches currently planed behavior.
| From one of already imported hosts run: | ||
| ``gluster peer probe [new_host]`` | ||
| where ``[new_host]`` is host that is going to be used to expand cluster. | ||
| Repeat for all new hosts. |
Contributor
There was a problem hiding this comment.
True, but that could be covered in another test case.
Contributor
|
I need to update this to convey a new way of expand. |
mbukatov
approved these changes
Jun 15, 2018
Contributor
mbukatov
left a comment
mbukatov
left a comment
There was a problem hiding this comment.
Looks good, thanks for quick update.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: Tendrl/specifications#254