Open
Conversation
fix: Replace obsolete MAINTAINER tag docs: Instructions on how to use each of the Dockerfiles
mohamedOuladi
suggested changes
May 3, 2022
| ARG BACKEND_ARGO="wipp-backend-argo-workflows" | ||
|
|
||
| COPY pom.xml /usr/local/${BACKEND_ROOT}/pom.xml | ||
| COPY ${BACKEND_NAME} /usr/local/${BACKEND_ROOT}/${BACKEND_NAME} |
Collaborator
There was a problem hiding this comment.
Fix typo. This should be BACKEND_APP instead of BACKEND_NAME
| ARG BACKEND_CORE="wipp-backend-core" | ||
| ARG BACKEND_ARGO="wipp-backend-argo-workflows" | ||
|
|
||
| COPY pom.xml /usr/local/${BACKEND_ROOT}/pom.xml |
Collaborator
There was a problem hiding this comment.
Would it make sense to define a WORKDIR (/opt for example) instead of copying folders to /usr/local/?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DockerfiletoDockerfile.localdevas this file requires building of the Java artifact on the host (and therefore Java/Maven installed). This Dockerfile facilitates a rapid development mode when developer has all the tools installed on the host machine and changes code frequently.Dockerfilewhich utilizes two-stage build and does not require anything to be installed on the host other than Docker to produce the final image. First stage uses official Maven image (maven:3.8.3-jdk-8) to build the Java artifact; second stage uses the sameopenjdk:8-jdk-alpineimage as before for the runtime image. The first stage is only used to build the artifact and then simply discarded (like a rocket stages do), so we don't carry Maven tools into production container. This Dockerfile is meant for CI pipelines or users who can't/don't want to install Java/Maven toolchain on their host machine, but still want to build the latest Docker image from WIPP-backend repo.MAINTAINERtag in favor of the labelorg.opencontainers.image.authorsas recommended in the official docs: https://docs.docker.com/engine/reference/builder/#maintainer-deprecated.