feat: Controller para obter o currículo base do Bacharelado em Ciência da Computação#23
Open
feat: Controller para obter o currículo base do Bacharelado em Ciência da Computação#23
Conversation
Contributor
Author
|
Esqueci de marcar, precisa da branch feature/models |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new controller to fetch the base curriculum for the Bachelor’s in Computer Science (BCC) and select the most recent mandatory record per subject.
- Introduces
TestControllerwithgetMandatoryFromBCCmethod - Queries
CurriculumTablefor mandatory entries matching a curriculum code prefix - Groups results by subject and picks the latest entry for each
Comments suppressed due to low confidence (4)
app/Http/Controllers/CourseController.php:6
- The class name
TestControllerdoes not match the file name or its purpose. Rename it toCourseController(or another meaningful name) to keep naming consistent.
class TestController extends Controller
app/Http/Controllers/CourseController.php:8
- Add a docblock to explain the purpose of this method, its parameters (e.g., format of
$curriculumCode), and the return type to improve maintainability.
public function getMandatoryFromBCC($curriculumCode)
app/Http/Controllers/CourseController.php:1
- There are no tests covering this new controller method. Consider adding unit or integration tests to validate query logic and grouping behavior.
<?php
app/Http/Controllers/CourseController.php:10
- PHP uses
.for string concatenation, not+. Change$curriculumCode + "%"to$curriculumCode . "%"to build the LIKE pattern correctly.
$baseCurriculum = CurriculumTable::where("id_curriculum", "like", $curriculumCode + "%")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
O que está caindo dos meus olhos