fix: planController ajusta o semestre das matérias concluídas#52
Merged
fix: planController ajusta o semestre das matérias concluídas#52
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the semester is correctly updated for already-saved plans when they’re marked as completed, and it tidies up brace placement in the completed method.
- Assign semester to existing plans before marking them completed in
syncWithReplication(). - Normalize the
} else {formatting and counter initialization incompleted().
Comments suppressed due to low confidence (2)
app/Http/Controllers/PlanController.php:214
- Add or update unit tests to cover the new semester assignment logic when marking a saved plan as completed, ensuring this behavior is validated and protected against regressions.
$savedPlan->semester = $semesterId;
app/Http/Controllers/PlanController.php:276
- [nitpick] The brace placement here differs from the rest of the file’s style; align this with the project’s established convention (e.g., keep
elseon its own line or consistently use} else {).
} else {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.