Skip to content

fix: planController ajusta o semestre das matérias concluídas#52

Merged
KakeyaK merged 1 commit intomainfrom
hotfix/CompletedSemestersForTransferStudents
Jul 3, 2025
Merged

fix: planController ajusta o semestre das matérias concluídas#52
KakeyaK merged 1 commit intomainfrom
hotfix/CompletedSemestersForTransferStudents

Conversation

@KakeyaK
Copy link
Copy Markdown
Contributor

@KakeyaK KakeyaK commented Jul 3, 2025

No description provided.

@KakeyaK KakeyaK requested a review from Copilot July 3, 2025 00:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that the semester is correctly updated for already-saved plans when they’re marked as completed, and it tidies up brace placement in the completed method.

  • Assign semester to existing plans before marking them completed in syncWithReplication().
  • Normalize the } else { formatting and counter initialization in completed().
Comments suppressed due to low confidence (2)

app/Http/Controllers/PlanController.php:214

  • Add or update unit tests to cover the new semester assignment logic when marking a saved plan as completed, ensuring this behavior is validated and protected against regressions.
                        $savedPlan->semester = $semesterId;

app/Http/Controllers/PlanController.php:276

  • [nitpick] The brace placement here differs from the rest of the file’s style; align this with the project’s established convention (e.g., keep else on its own line or consistently use } else {).
        } else {

@KakeyaK KakeyaK merged commit e2f130d into main Jul 3, 2025
1 check passed
@KakeyaK KakeyaK deleted the hotfix/CompletedSemestersForTransferStudents branch July 3, 2025 00:26
@KakeyaK KakeyaK restored the hotfix/CompletedSemestersForTransferStudents branch July 3, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants