2 changes - git hash printing + consistency check#4
Open
goracle wants to merge 14 commits intousqcd-software:masterfrom
Open
2 changes - git hash printing + consistency check#4goracle wants to merge 14 commits intousqcd-software:masterfrom
goracle wants to merge 14 commits intousqcd-software:masterfrom
Conversation
(hash is latest commit in the tree. This is useful for recreation work and identifying old binaries.)
(useful for reproduction work and identifying and tagging old binaries).
(prevents automake from overwriting this functionality from Makefile.in)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: Do not pull. The feature #2 does not work. #1 does work is simple enough that it should be added.
Hi,
There are two changes here:
EDIT: #2 does not work. I need to read some docs related to autoreconf to figure out why.
2) Printing of the git hash: During the initialization of qmp, print the current git hash. This is a feature request. This feature works by calling git from within make, printing the hash in a brief header file as a pre-processor defined string, then using this string in a print statement within qmp init message passing. Rationale(s): This feature is helpful in terms of identifying old binaries, doing recreation work, and general debugging. I have implemented and used this feature extensively. In particular, I have implemented it in my production copies of Grid (see my github page for this), CPS, and now QMP. This feature should be invisible to the user. The invisibility trades off with not forcing a correct hash to be printed every time a new binary is compiled, but the printed hash should be taken as a good hint as to the provenance of the binary.
There may be other ways to implement such a feature, and I would be open to hearing them, as well as hearing any other comments/reactions to this idea. Feel free to split these as necessary. Thanks.