Fix: Conditionally adds SteamClientComponent

[joshuatam]

Only adds the SteamClientComponent if the container is not launching real Steam.

This change is part of the effort to remove steampipe when using the real Steam client.

---

Summary by cubic

Conditionally adds SteamClientComponent only when the container is not launching the real Steam client. This supports removing steampipe for real Steam runs and prevents redundant Steam initialization.

^{Written for commit dd9eb78. Summary will update on new commits.}

Summary by CodeRabbit

• Bug Fixes
  • Fixed X Server component initialization logic to properly respect Steam launch mode configuration settings.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Modified setupXEnvironment in XServerScreen.kt to conditionally add SteamClientComponent based on the container.isLaunchRealSteam flag. The component is now only added when real Steam launch is disabled, altering the environment initialization path.

Changes

Cohort / File(s)	Change Summary
Conditional Steam Environment Setup app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt	Added guard condition to setupXEnvironment: SteamClientComponent is now only added when container.isLaunchRealSteam is false. Modifies component initialization flow based on Steam launch mode selection.

Possibly related PRs

• Revert to launching game via steam if steam client enabled #251: Adds a real-Steam launch pathway to XServerScreen.kt alongside this change that gates SteamClientComponent addition by the same flag.

Poem

🐰 A guard clause hops into place,
When Steam takes the real launch race,
No false client need appear,
Control flows become crystal clear! ✨

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: adding conditional logic for SteamClientComponent initialization based on the container's Steam launch mode.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 1 file

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt`:
- Around line 1836-1839: The code makes SteamClientComponent optional when
container.isLaunchRealSteam is true, but shiftXEnvironmentToContext (and other
callers) still assume it exists and re-adds or accesses it unconditionally;
update shiftXEnvironmentToContext to null-check for SteamClientComponent (and
any other places re-adding or dereferencing it) before using or adding it, e.g.,
retrieve the component via environment.getComponent(SteamClientComponent::class)
and only call environment.addComponent(...) or access its members if the
retrieved value is non-null, handling the absent-case gracefully (skip
adding/using or provide fallback behavior).

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Guard downstream access to SteamClientComponent when real Steam is used.

Line 1836-1839 makes the component optional; shiftXEnvironmentToContext still unconditionally re-adds it (Line 1629), which can become null and crash when the environment is shifted. Add a null-guard there (and any other callers that assume the component exists).

✅ Suggested fix (null-guard in shiftXEnvironmentToContext)

-    environment.addComponent(xEnvironment.getComponent<SteamClientComponent>(SteamClientComponent::class.java))
+    xEnvironment.getComponent<SteamClientComponent>(SteamClientComponent::class.java)
+        ?.let { environment.addComponent(it) }

🤖 Prompt for AI Agents

In `@app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt` around
lines 1836 - 1839, The code makes SteamClientComponent optional when
container.isLaunchRealSteam is true, but shiftXEnvironmentToContext (and other
callers) still assume it exists and re-adds or accesses it unconditionally;
update shiftXEnvironmentToContext to null-check for SteamClientComponent (and
any other places re-adding or dereferencing it) before using or adding it, e.g.,
retrieve the component via environment.getComponent(SteamClientComponent::class)
and only call environment.addComponent(...) or access its members if the
retrieved value is non-null, handling the absent-case gracefully (skip
adding/using or provide fallback behavior).