Skip to content

sort: fix infinite loop on --files0-from read error#11504

Merged
cakebaker merged 1 commit intouutils:mainfrom
vitkyrka:sort
Mar 26, 2026
Merged

sort: fix infinite loop on --files0-from read error#11504
cakebaker merged 1 commit intouutils:mainfrom
vitkyrka:sort

Conversation

@vitkyrka
Copy link
Copy Markdown
Contributor

If the read from the --files0-from file results in a permanent error, we end up in an infinite loop.

Clippy will detect this in the future, see rust-lang/rust-clippy#16763.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cp/link-heap is now passing!
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

If the read from the `--files0-from` file results in a permanent error,
we end up in an infinite loop.
@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Congrats! The gnu test tests/cp/link-heap is now passing!
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@vitkyrka vitkyrka marked this pull request as ready for review March 26, 2026 11:52
@cakebaker cakebaker merged commit b0d504c into uutils:main Mar 26, 2026
161 of 162 checks passed
@cakebaker
Copy link
Copy Markdown
Contributor

Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants