Skip to content

Conversation

@wntiv-main
Copy link

No description provided.

@wntiv-main
Copy link
Author

should fixes #7
sorry i dont fully understand the full intent of your code, but my (albeit short) testing seems to indicate this fixes the issue and is still functional. i'm uncertain whether deleting from the songs "cache" is needed, or a good idea - as far as i can see, there are so many songs at this point that caching them all isnt neccesarily a good idea. wouldnt browser cache also cover this anyways? in any case, feel free to adapt this pr as nesseccary.

thanks for all your work putting this together :3

@yellowsink
Copy link
Member

ah shit nice catch, oops. Sorry it took this long for me to get around to seeing this, I'll take a look at this after I'm done with my current work on switching from song chunks to livestreaming (this is still relevant as older versions of safari will have to fall back to the old codebase for now!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants