Skip to content

Fixing attribute replace regex#3

Open
pablokbs wants to merge 1 commit intovFense:masterfrom
pablokbs:patch-1
Open

Fixing attribute replace regex#3
pablokbs wants to merge 1 commit intovFense:masterfrom
pablokbs:patch-1

Conversation

@pablokbs
Copy link
Copy Markdown

@pablokbs pablokbs commented Dec 1, 2015

This was causing an odd name after the replacement

# before my change
irb(main):017:0* "muzli-node-ubuntu-1404".gsub(/-|\.|/, '_')
=> "_m_u_z_l_i__n_o_d_e__u_b_u_n_t_u__1_4_0_4_"
# after my change
irb(main):018:0> "muzli-node-ubuntu.1404".gsub(/-|\./, '_')
=> "muzli_node_ubuntu_1404"

This was causing an odd name after the replacement

```
# before my change
irb(main):017:0* "muzli-node-ubuntu-1404".gsub(/-|\.|/, '_')
=> "_m_u_z_l_i__n_o_d_e__u_b_u_n_t_u__1_4_0_4_"
# after my change
irb(main):018:0> "muzli-node-ubuntu.1404".gsub(/-|\./, '_')
=> "muzli_node_ubuntu_1404"
```
@arukaen
Copy link
Copy Markdown

arukaen commented Dec 1, 2015

👍

@pablokbs
Copy link
Copy Markdown
Author

pablokbs commented Dec 1, 2015

LGTM 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants